Last modified: 2014-02-12 23:48:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53586, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 51586 - Liquid threads and mobile talk dislike each other


Summary:	Liquid threads and mobile talk dislike each other

Status:	RESOLVED FIXED

Product:	MobileFrontend
Classification:	Unclassified
Component:	beta (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized normal
Target Milestone:	---
Assigned To:	Max Semenik

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-07-18 00:03 UTC by Jon
Modified:	2014-02-12 23:48 UTC (History)
CC List:	8 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Jon 2013-07-18 00:03:33 UTC

Go to https://m.mediawiki.org/wiki/Requests_for_comment/Scoping_site_CSS
Click talk.
Nothing shows despite there being underlying content but you can add topics..

I hate liquid threads but not sure what we should do here.

Comment 1 Maryana Pinchuk 2013-07-18 00:47:27 UTC

Honestly, we should really propose killing LQT on mediawiki.org - it's going to be replaced by Flow in the (hopefully) not-too-long term anyway...

Comment 2 Alex Monk 2013-07-18 00:51:21 UTC

LQT can't go until someone comes up with a way to extract LQT conversations and either put them in a format Flow can understand or output as a normal talk page.

Comment 3 Jon 2013-08-09 04:56:49 UTC

Currently the response for:
https://m.mediawiki.org/w/api.php?format=json&action=mobileview&page=Talk%3ARequests+for+comment%2FScoping+site+CSS&variant=en&redirect=yes&prop=sections%7Ctext&noheadings=yes&sectionprop=level%7Cline%7Canchor&sections=all

is:
{"warnings":{"main":{"*":"Unrecognized parameter: 'redirects'"}},"mobileview":{"sections":[{"id":0,"text":""}]}}

Could the api return something different when liquid threads is being used?

Comment 4 Jon 2013-08-23 18:51:50 UTC

Poke.. anyway to find out when a page has LiquidThreads enabled?

Comment 5 Jon 2013-08-26 21:38:40 UTC

LiquidThread invokes onAPIQueryAfterExecute and seems to add a parameter. Could we somehow incorporate this in the above api response?

https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FLiquidThreads/4f2fbead90ac9f8373d2766c6460919b8f4bffce/classes%2FHooks.php#L888

Comment 6 Jon 2013-08-26 21:38:57 UTC

(Question aimed at Max)

Comment 7 Jon 2013-08-26 21:40:52 UTC

If we can, I suggest we just display a message saying "talk not currently available on this page".

Comment 8 Jon 2013-09-05 19:12:18 UTC

https://gerrit.wikimedia.org/r/81580 kicks this off

Comment 9 Jon 2013-09-16 20:21:04 UTC

My api seems to always say it is not LQT enabled so not sure if this patch worked correctly..

Comment 10 Gerrit Notification Bot 2013-09-16 23:51:45 UTC

Change 84466 had a related patch set uploaded by Jdlrobson:
Redirect to talk page when liquid threads enabled

https://gerrit.wikimedia.org/r/84466

Comment 11 Gerrit Notification Bot 2013-09-23 20:31:25 UTC

Change 84466 merged by jenkins-bot:
Redirect to talk page when liquid threads enabled

https://gerrit.wikimedia.org/r/84466

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links