Last modified: 2013-07-22 23:17:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53644, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 51644 - centralauth_Token only set for local wiki on login
centralauth_Token only set for local wiki on login
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CentralAuth (Other open bugs)
unspecified
All All
: High normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-18 23:18 UTC by Chris Steipp
Modified: 2013-07-22 23:17 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---
bjorsch: Backport_WMF+


Attachments

Description Chris Steipp 2013-07-18 23:18:18 UTC
When a user logs in, and they have checked "Keep me logged in", and they have a global user, the centralauth_Token cookie is only set for the wiki where they are logging in. It is not set for loginwiki, or any of the other SUL wikis.

So the user will be logged out of all the other SUL wikis except the one where they logged in, if they close their browser and then return.

I think we should also set it on loginwiki, so that they will be logged in centrally for 30 days. Other attached wikis can rely on the login check to log them in.
Comment 1 Marco 2013-07-19 12:03:20 UTC
I remember this has been working before.
Why was this changed in the first place?
Comment 2 Gerrit Notification Bot 2013-07-19 20:44:16 UTC
Change 74682 had a related patch set uploaded by Anomie:
Have Special:CentralAutoLogin honor "Keep me logged in"

https://gerrit.wikimedia.org/r/74682
Comment 3 Brad Jorsch 2013-07-19 20:54:48 UTC
(In reply to comment #1)
> I remember this has been working before.
> Why was this changed in the first place?

Considering that all the auto-login logic and a fair bit of the regular login logic had to be rewritten, and in fact were rewritten several times during the development process as constraints shifted, chances are it was accidental.
Comment 4 Gerrit Notification Bot 2013-07-22 19:53:44 UTC
Change 74682 merged by jenkins-bot:
Have Special:CentralAutoLogin honor "Keep me logged in"

https://gerrit.wikimedia.org/r/74682
Comment 5 Brad Jorsch 2013-07-22 20:12:07 UTC
Change is merged now, but leaving this open for the moment since this should probably be backported to wmf10 and wmf11, instead of waiting for wmf12.
Comment 6 Gerrit Notification Bot 2013-07-22 21:39:17 UTC
Change 75251 had a related patch set uploaded by Anomie:
Have Special:CentralAutoLogin honor "Keep me logged in"

https://gerrit.wikimedia.org/r/75251
Comment 7 Gerrit Notification Bot 2013-07-22 21:40:09 UTC
Change 75251 merged by jenkins-bot:
Have Special:CentralAutoLogin honor "Keep me logged in"

https://gerrit.wikimedia.org/r/75251
Comment 8 Gerrit Notification Bot 2013-07-22 23:01:16 UTC
Change 75261 had a related patch set uploaded by Anomie:
Update CentralAuth to fix bug 51644

https://gerrit.wikimedia.org/r/75261
Comment 9 Gerrit Notification Bot 2013-07-22 23:01:30 UTC
Change 75262 had a related patch set uploaded by Anomie:
Update CentralAuth to fix bug 51644

https://gerrit.wikimedia.org/r/75262
Comment 10 Gerrit Notification Bot 2013-07-22 23:03:24 UTC
Change 75261 merged by Anomie:
Update CentralAuth to fix bug 51644

https://gerrit.wikimedia.org/r/75261
Comment 11 Gerrit Notification Bot 2013-07-22 23:03:31 UTC
Change 75262 merged by Anomie:
Update CentralAuth to fix bug 51644

https://gerrit.wikimedia.org/r/75262
Comment 12 Brad Jorsch 2013-07-22 23:17:57 UTC
Deployed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links