Last modified: 2014-02-28 23:04:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53664, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 51664 - VisualEditor: Surface should respect the default state of collapseable templates
VisualEditor: Surface should respect the default state of collapseable templates
Status: ASSIGNED
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: Low minor
: ---
Assigned To: Editing team bugs – take if you're interested!
:
Depends on: 51565
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-19 08:42 UTC by Chris McKenna
Modified: 2014-02-28 23:04 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Related render problems (438.65 KB, image/png)
2013-10-01 04:01 UTC, John Mark Vandenberg
Details

Description Chris McKenna 2013-07-19 08:42:34 UTC
A user on English Wikipedia requests that templates such as navigation boxes that display as collapsed by default when viewing should display as collapsed by default when editing.

"Currently, navigation boxes are always uncollapsed when editing. This can be quite annoying when having to deal with big ones like {{The Beatles}}, e.g. on "I'm a Loser", also it might be confusing editors into believing that this part of a page can easily be edited."
Comment 1 Derk-Jan Hartman 2013-07-19 19:22:40 UTC
First of all, this requires fixes for bug 51565 to be deployed, and then we need to fix the NavFrame and CollapsibleTable scripts in en:wp:MediaWiki:Common.js to use the same hooks.
Comment 2 John Mark Vandenberg 2013-10-01 03:40:15 UTC
(In reply to comment #1)
> First of all, this requires fixes for bug 51565 to be deployed, and then we
> need to fix the NavFrame and CollapsibleTable scripts in
> en:wp:MediaWiki:Common.js to use the same hooks.

That change has been made on enwp by TheDJ/hartman (cc'd)

https://en.wikipedia.org/w/index.php?title=MediaWiki:Common.js&diff=570114240&oldid=569893356

The templates are yet not collapsing; is there more development needed in VE product or in Common.js ?

I think 'collapse' need more special handling in VE (possibly even in parsoid); in order to be WYSIWYG.
1. The user can change the collapse state of templates in the VE dialog editor, and that change should be reflected in the VE after the changes are applied.
2. The user should be able to collapse and uncollapse a collapse-able template in order 
2.1 to visualise how the page will look in each mode
2.2 hide/unhide collapse-able templates that are consuming precious screen real estate (this should be a separate enhancement)

Perhaps this feature should be dependent on bug 30352.
Comment 3 John Mark Vandenberg 2013-10-01 04:01:29 UTC
Created attachment 13417 [details]
Related render problems

This is a related problem, which would not be noticable if it was not for this bug.

https://en.wikipedia.org/w/index.php?title=Anarchism&veaction=edit

When in normal view mode (not VE), expand all of those sidebars
A large area of whitespace opens up above "Internal issues and debates", and the images appear there.

In the VE, that whitespace is filled with text, which causes the images to be pushed further down in the content, eventually slipping into the References section, and on Firefox the images even overlaps the References section.

I haven't investigated what is causing the VE vs non-VE rendering differences, but collapse is clearly the reason this rendering difference is a significant problem that all VE users face, rather than a minor glitch that only appears when the user is silly enough to alter all sidebars to be expanded.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links