Last modified: 2013-09-18 15:20:23 UTC
ModifyEntityTestBase is doing very bad stuff and is written very poorly. It is in desperate need of refactoring and same goes for any related api tests that are using code from ModifyEntityTestBase.
I have been working on this all week, took a while to make sure I started in the right place, as naturally if you change one thing somewhere it breaks everything everywhere else... Initial path is https://gerrit.wikimedia.org/r/78364 which changes the way entities are created and managed for the tests as well as implementing is usage in all tests that mess about with entities. This means it is now safe to fix all of the tests without worrying about bad id values etc. Also https://gerrit.wikimedia.org/r/78368 refactors the SetDescription/Label test and their base to make them better! :) Still a long way to go refactoring all of the other tests and making sure they actually test what we want.
Change 78368 had a related patch set uploaded by Addshore: Refactor LangAttribute Api Test Cases https://gerrit.wikimedia.org/r/78368
Change 78364 had a related patch set uploaded by Addshore: Refactor EntityTestBase https://gerrit.wikimedia.org/r/78364
Change 78078 had a related patch set (by Addshore) published: Refactor SetAliasesTest https://gerrit.wikimedia.org/r/78078
Change 78364 merged by jenkins-bot: Refactor EntityTestBase https://gerrit.wikimedia.org/r/78364
Change 78368 merged by jenkins-bot: Refactor LangAttribute Api Test Cases https://gerrit.wikimedia.org/r/78368
Change 78078 merged by jenkins-bot: Refactor SetAliasesTest https://gerrit.wikimedia.org/r/78078
