Last modified: 2014-08-29 10:35:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53701, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 51701 - VisualEditor: Auto-hide "You've entered wikimarkup" warning when the user has removed the markup
VisualEditor: Auto-hide "You've entered wikimarkup" warning when the user has...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Low enhancement
: VE-deploy-2014-02-13
Assigned To: Alex Monk
:
: 52155 (view as bug list)
Depends on: 51338
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-19 20:30 UTC by Oliver Keyes
Modified: 2014-08-29 10:35 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Oliver Keyes 2013-07-19 20:30:39 UTC
At the moment wikimarkup being entered into the VE triggers a notice warning the user that it won't work - this notice then has to be actively dismissed. It'd be nice if, should the user remove the problematic markup, the notice would vanish.

I'm popping this in as a low-priority enhancement: I appreciate the VE team has active breakage to focus on.
Comment 1 Oliver Keyes 2013-08-01 18:28:11 UTC
*** Bug 52155 has been marked as a duplicate of this bug. ***
Comment 2 Chris McKenna 2013-08-06 18:01:09 UTC
The popup should also be closed automatically after the "save page" button has been pressed. At that point it's clear that the user is not going to remove any markup that still remains (for whatever reason) so the notice serves no other purpose and just gets in the way of the edit summary dialog.
Comment 3 Dan Garry 2013-10-02 14:34:04 UTC
(In reply to comment #2)
> The popup should also be closed automatically after the "save page" button
> has
> been pressed. At that point it's clear that the user is not going to remove
> any
> markup that still remains (for whatever reason) so the notice serves no other
> purpose and just gets in the way of the edit summary dialog.

There's an issue with this though, in that the popup hovers over the 'Save page' button so I couldn't actually click 'Save page' very easily. It wasn't at all clear to me that clicking anywhere on the popup would close it.
Comment 4 Chris McKenna 2013-10-02 15:22:52 UTC
(In reply to comment #3)
> There's an issue with this though, in that the popup hovers over the 'Save
> page' button so I couldn't actually click 'Save page' very easily. It wasn't
> at
> all clear to me that clicking anywhere on the popup would close it.

You aren't the first person to say that - see bug 52386
Comment 5 Gerrit Notification Bot 2014-01-30 01:36:58 UTC
Change 110295 had a related patch set uploaded by Alex Monk:
Hide wikitext warning notification when the user removes the markup

https://gerrit.wikimedia.org/r/110295
Comment 6 Gerrit Notification Bot 2014-02-07 22:54:58 UTC
Change 110295 merged by jenkins-bot:
Hide wikitext warning notification when the user removes the markup

https://gerrit.wikimedia.org/r/110295
Comment 7 Alex Monk 2014-02-07 23:22:19 UTC
That area of code could do with some rethinking, but this is basically done.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links