Last modified: 2014-02-13 10:50:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53718, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 51718 - Fix selser result pass/failure detection in parserTests.js
Fix selser result pass/failure detection in parserTests.js
Status: NEW
Product: Parsoid
Classification: Unclassified
tests (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-19 22:53 UTC by ssastry
Modified: 2014-02-13 10:50 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description ssastry 2013-07-19 22:53:49 UTC
When selser runs (html2wt) on modified HTML, we have to figure out whether the serialized wikitext is correct or not.  However, there is no original wikitext to compare against since the DOM has been modified.

Currently, parserTests runs wt2wt on the same modified HTML and compares selser output with wt2wt output.  wt2wt uses the regular full serializer.  This pass/failure detection implicitly assumes that the output from wt2wt is correct.  However, this is flawed -- it might actually be the case that selser output is correct and wt2wt is incorrect since wt2wt might be normalizing wikitext whereas selser wont (which is the whole point of selser, so to speak).  This was not as much of an issue till a while back since wt2wt was normalizing less and parserTests used to run in rt-testing mode which used src-based rting for templates and the like.  However, this is becoming more of a problem as we move towards greater normalization (ex: bug 51004), and when the regular serializer no longer run in rt-testing mode.

So, we need to figure out a more robust solution to this problem.
Comment 1 Gerrit Notification Bot 2013-09-25 04:00:25 UTC
Change 85952 had a related patch set uploaded by Arlolra:
WIP: Remember the output of failing (blacklisted) tests

https://gerrit.wikimedia.org/r/85952
Comment 2 Gerrit Notification Bot 2013-10-01 22:33:58 UTC
Change 85952 merged by jenkins-bot:
Remember the output of failing (blacklisted) tests

https://gerrit.wikimedia.org/r/85952
Comment 3 Andre Klapper 2014-02-12 15:58:23 UTC
Subbu / Gabriel: Patch was merged month ago - is there more work left here, or can you close this ticket as RESOLVED FIXED?
Comment 4 ssastry 2014-02-12 18:39:14 UTC
We merged a different workable solution for now, but I still keep hoping for a smarter solution to turn up. Leaving this here in case someone has a smart idea for this when they are bored and idle and thinking about this. ;-)
Comment 5 Arlo Breault 2014-02-12 19:48:53 UTC
weird. why is marcoil suddenly the default?
Comment 6 Marc Ordinas i Llopis 2014-02-13 10:50:52 UTC
I think I'm the default for Parsoid/tests :)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links