Last modified: 2014-01-31 05:23:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53728, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 51728 - Use correct annotations upon view of old revision


Summary:	Use correct annotations upon view of old revision

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	Annotator (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	---
Assigned To:	Gabriel Birke

URL:
Whiteboard:
Keywords:

Depends on:	51594
Blocks:
	Show dependency tree / graph

Reported:	2013-07-20 02:10 UTC by Matthew Flaschen
Modified:	2014-01-31 05:23 UTC (History)
CC List:	4 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Use current revision (510 bytes, patch) 2014-01-28 16:09 UTC, Gabriel Birke	Details
Add an attachment (proposed patch, testcase, etc.)

Description Matthew Flaschen 2013-07-20 02:10:16 UTC

Right now, when you view an old revision (e.g. through the history tab), it will show (or try to show) annotations for the latest version.

This will be easier to fix if bug 51594 is fixed first.

Comment 1 Gabriel Birke 2014-01-28 16:09:26 UTC

Created attachment 14397 [details]
Use current revision

This patch uses the revision number of the currently displayed page.

Comment 2 Andre Klapper 2014-01-28 21:04:09 UTC

Hi Gabriel! Thanks for your patch!

You are welcome to use Developer access
  https://www.mediawiki.org/wiki/Developer_access
to submit this as a Git branch directly into Gerrit:
  https://www.mediawiki.org/wiki/Git/Tutorial

Putting your branch in Git makes it easier to review it quickly. If you don't want to set up Git/Gerrit, you can also use https://tools.wmflabs.org/gerrit-patch-uploader/
Thanks again! We appreciate your contribution.

Comment 3 Matthew Flaschen 2014-01-29 00:48:22 UTC

Gabriel, if you have issues putting the patch on Gerrit, you can join #wikimedia-growth on Freenode (http://webchat.freenode.net/?channels=#wikimedia-growth), and I'd be glad to help you out (I'm superm401).

Comment 4 Gabriel Birke 2014-01-29 10:57:59 UTC

Thanks for the excellent tutorial, I've sent the patch for review.

Comment 5 Andre Klapper 2014-01-29 11:27:21 UTC

https://gerrit.wikimedia.org/r/#/c/110157/

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links