Last modified: 2013-07-30 22:09:37 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53741, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 51741 - Support references with content defined inside <references/> block (<ref name=abc /> <references><ref name=abc>Content</ref></references>)
Support references with content defined inside <references/> block (<ref name...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Data Model (Other open bugs)
unspecified
All All
: High major
: VE-deploy-2013-08-15
Assigned To: Ed Sanders
:
Depends on:
Blocks: ve-nonenglish
  Show dependency treegraph
 
Reported: 2013-07-20 10:53 UTC by Bartosz Dziewoński
Modified: 2013-07-30 22:09 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bartosz Dziewoński 2013-07-20 10:53:36 UTC
VE should support references with content defined inside <references/> block. This style is widely used on the Polish Wikipedia to keep the wikitext mostly readable.

-- 8< ---------
Some text.<ref name=abc />

<references><ref name=abc>Content</ref></references>
-- 8< ---------

Live example: https://pl.wikipedia.org/w/index.php?title=Wikipedysta:Matma_Rex/brudnopis&direction=next&oldid=37095835

And it would be really cool if it could also supports this (but I'm not holding my breath):

-- 8< ---------
Some text.{{r|abc}}

{{reflist|refs=<ref name=abc>Content</ref>}}
-- 8< ---------

About this feature on en.wp help pages: [[Help:Footnotes#Footnotes: list-defined references]]
Comment 1 Bartosz Dziewoński 2013-07-20 11:00:36 UTC
This would require some help from the Parsoid side:
* VE requires knowing the generated HTML for ref bodies, and Parsoid
  currently only provides these for inline refs with bodies (<ref
  name=asd>body</ref>), as (data-mw).html.body.
* The simplest way to do this seems to be providing generated HTML for
  refs inside <references/> as an array of ref bodies inside
  <references/>'s data-mw.
Comment 2 John Mark Vandenberg 2013-07-24 09:32:32 UTC
When I try your sandbox, I can edit the references list using wikitext in the template dialog.

On German Wikipedia, this article is similar but has templates inside <references/>
https://de.wikipedia.org/wiki/This_Is_War?veaction=edit
It isnt editable with this notice repeating many times:
  "This reference is defined in a template or other generated block, and for now can only be edited in source mode"
Comment 3 Gerrit Notification Bot 2013-07-25 17:14:29 UTC
Change 75912 had a related patch set uploaded by Esanders:
[WIP] Ref in references support

https://gerrit.wikimedia.org/r/75912
Comment 4 John Mark Vandenberg 2013-07-25 23:09:01 UTC
On Parsoid topfail there are several dewp entries for <!-- comments --> within <references/> being moved around.  I couldnt reproduce those bugs, probably because of selective serialization.  If this is now editable, these dirty diffs may start happening in production.  It would be good to test, but I suspect impact is quite low because I checked 20 featured articles and 10 good articles on dewp, and none had these comments within <references/>.

http://parsoid.wmflabs.org:8001/latestresult/de/Flugplatz_St._Michaelisdonn
http://parsoid.wmflabs.org:8001/latestresult/de/ARO_Heimtextilien

And here is one for whitespace within <references/>

http://parsoid.wmflabs.org:8001/latestresult/de/Trigonias
Comment 5 Gerrit Notification Bot 2013-07-30 21:53:02 UTC
Change 75912 merged by jenkins-bot:
Ref in references support

https://gerrit.wikimedia.org/r/75912
Comment 6 James Forrester 2013-07-30 22:09:37 UTC
This is now merged and will get deployed today; however, to actually do what people want depends on a change in Parsoid that will get deployed tomorrow.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links