Last modified: 2013-07-22 14:32:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53786, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 51786 - Parsoid doesn't handle unclosed table attributes (because of missing quote) in all scenarios
Parsoid doesn't handle unclosed table attributes (because of missing quote) i...
Status: RESOLVED DUPLICATE of bug 49839
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-21 21:53 UTC by Chris McKenna
Modified: 2013-07-22 14:32 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Chris McKenna 2013-07-21 21:53:16 UTC
A user on the English Wikipedia reports that when saving an edit to the lead of an article in Visual Editor, a table lower down the page was "modified and broken":

https://en.wikipedia.org/w/index.php?title=2013_Hillsboro_Hops_season&diff=565234138&oldid=565068343 

Note that it didn't alter the opening of the table.

About a week prior, an edit with VE to a page in my userspace that contains an unfinished and unclosed table similarly had all the table syntax deleted exlcuding the first line of the table. https://en.wikipedia.org/w/index.php?title=User:Thryduulf/Hierarchy_of_content_decisions&diff=564156742&oldid=564156599 

This is obviously very broken in that it leads to significant content corruption, even running together words in the in the second example.

It doesn't happen every time, for example I wasn't able to reproduce it in my sandbox https://en.wikipedia.org/w/index.php?title=User:Thryduulf/sandbox&diff=565239631&oldid=565239447 and earlier tests showed that simply removing the closing |} is not sufficient to trigger this.

Possibly this is related to bug 50104 and/or 51172
Comment 1 Chris McKenna 2013-07-21 21:53:40 UTC
Sorry that's bug 51172
Comment 2 ssastry 2013-07-22 14:32:30 UTC
The problem with [[Hillsboro_Hops_season]] is unclosed quotes for the bgcolor attribute (see snippet below):

...
|- align="center" bgcolor="
...

Parsoid does attempt to deal with unclosed quotes in table attributes, but its handing can be further improved.  (See bug 49839).  For now, I would recommend fixing the page.

You can reproduce the bug with the following snippet in your sandbox (all the wikitext elements below are necessary for the bug to show up in its nasty form -- with some pieces removed, Parsoid handles it much better).

:{|
|-
! bgcolor="bbbbbb" | Game postponed
|}

{|
|- bgcolor="
| a || b
|}

*** This bug has been marked as a duplicate of bug 49839 ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links