Last modified: 2013-08-05 18:15:08 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53806, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 51806 - VisualEditor shows rowspan="4" on template generated tables
VisualEditor shows rowspan="4" on template generated tables
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Gabriel Wicke
https://pt.wikipedia.org/wiki/La_Liga...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-22 12:18 UTC by Helder
Modified: 2013-08-05 18:15 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot of the table (45.08 KB, image/png)
2013-07-22 12:18 UTC, Helder
Details

Description Helder 2013-07-22 12:18:58 UTC
Created attachment 12914 [details]
Screenshot of the table

See the link above and the attached screenshot.
Comment 1 Roan Kattouw 2013-07-30 01:21:18 UTC
Parsoid bug: http://parsoid.wmflabs.org/pt/La_Liga_de_2006%E2%80%9307?oldid=36362539 (you'll have to scroll down quite a bit)
Comment 2 ssastry 2013-07-30 16:35:01 UTC
Buggy template: http://pt.wikipedia.org/w/index.php?title=Predefini%C3%A7%C3%A3o:Tabfootrow&action=edit

It should be "|rowspan=..." instead of "||rowspan=..."

echo "{|\n|foo{{User:Ssastry/Templates/tabfootrow|rows=2|content=foobar}}\n|}" | node parse

works properly with the correct wikitext.
Comment 3 ssastry 2013-07-30 16:36:27 UTC
I am not editing the template -- someone on pt wikipedia (matmarex) should verify that existing pages wont break with the change and do it.  But, offhand it does seem safe to fix.
Comment 4 Helder 2013-07-30 17:14:11 UTC
I left a message in the talk page of one of the articles which uses the template:
https://pt.wikipedia.org/wiki/Discuss%C3%A3o:Primeira_Liga_de_2013%E2%80%9314
and in the thread where its author announced the new template:
https://pt.wikipedia.org/wiki/WP:EA#Novas_predefini.C3.A7.C3.B5es_para_tabelas_de_futebol
Comment 5 Helder 2013-08-05 18:05:03 UTC
For now, I moved the relevant code from [[pt:Template:Tabfootrow]] to [[pt:Template:Tabfoot]] and then I updated the only two articles which uses that template and informed about this change in the talk page of one of them:
https://pt.wikipedia.org/wiki/Special:Contribs/Helder.wiki?dir=prev&offset=20130805170824&limit=11&uselang=en
Comment 6 ssastry 2013-08-05 18:15:08 UTC
Thanks for fixing the templates -- I will close this bug now without making any fixes in Parsoid.  While we could fix Parsoid to accommodate bugs in wikitext and templates (and there are several scenarios that we handle), for one-off scenarios, it is better to fix the templates/wikitext rather than clutter the Parsoid code base with exceptional conditions.  It is better in the long run and will enable maintenance of the code base.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links