Last modified: 2013-10-09 17:24:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53870, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 51870 - Changing HTML code for list output
Changing HTML code for list output
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
RelatedArticles (Other open bugs)
master
All All
: Unprioritized major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-23 11:37 UTC by RolandUnger
Modified: 2013-10-09 17:24 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description RolandUnger 2013-07-23 11:37:05 UTC
Please change the old code in RelatedArticles.class.php

	Html::closeElement( 'div' ) .
	Html::closeElement( 'div' ) .
	Html::openElement( 'div', array( 'id' => 'p-lang', 'class' => 'portal' ) ) .
	Html::element( 'h3', array(), wfMessage( 'relatedarticles-title' )->text() ) .
	Html::openElement( 'div', array( 'class' => 'body' ) ) .
	Html::openElement( 'ul', array( 'class' => 'body' ) ) .
	implode( '', $relatedArticles );

to

	Html::closeElement( 'div' ) .
	Html::closeElement( 'div' ) .
	Html::openElement( 'div', array( 'id' => 'p-relatedarticles', 'class' => 'portal', 'role' => 'navigation' ) ) .
	Html::element( 'h3', array(), wfMessage( 'relatedarticles-title' )->text() ) .
	Html::openElement( 'div', array( 'class' => 'body' ) ) .
	Html::openElement( 'ul' ) ) .
	implode( '', $relatedArticles );

In line 3 id was changed from p-lang to p-relatedarticles because p-lang is already used. In the same line the role attribute was added.

In line 4 h3 must now noted instead of the former h5.

Next to the last line the class="body" attribute was removed. No longer necessary.
Comment 1 RolandUnger 2013-07-24 05:42:54 UTC
Wrong id prevents Wikidata presenting "Languages" section
Comment 2 Gerrit Notification Bot 2013-07-25 14:22:53 UTC
Change 75872 had a related patch set uploaded by Aude:
(bug 51870) fix html in toolbox for related articles

https://gerrit.wikimedia.org/r/75872
Comment 3 RolandUnger 2013-07-25 16:25:55 UTC
The next to the last line should be:

Html::openElement( 'ul', array() ) .
Comment 4 Gerrit Notification Bot 2013-07-26 16:45:29 UTC
Change 75872 merged by Hoo man:
(bug 51870) fix html in toolbox for related articles

https://gerrit.wikimedia.org/r/75872
Comment 5 Lydia Pintscher 2013-09-23 10:20:35 UTC
This looks good now. I'm closing it. Please reopen with link if it is still an issue somewhere. Thanks :)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links