Last modified: 2013-10-09 17:24:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53871, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 51871 - Changing HTML coding for list output in Insider.class.php
Changing HTML coding for list output in Insider.class.php
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Insider (Other open bugs)
master
All All
: Unprioritized major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-23 11:43 UTC by RolandUnger
Modified: 2013-10-09 17:24 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description RolandUnger 2013-07-23 11:43:10 UTC
Please change the old code in Insider.class.php from

	Html::closeElement( 'div' ) .
	Html::closeElement( 'div' ) .
	Html::openElement( 'div', array( 'id' => 'p-lang', 'class' => 'portal' ) ) .
	Html::element( 'h3', array(), wfMessage( 'insider-title' )->text() ) .
	Html::openElement( 'div', array( 'class' => 'body' ) ) .
	Html::openElement( 'ul', array( 'class' => 'body' ) ) .
	implode( '', $insiders );

to

	Html::closeElement( 'div' ) .
	Html::closeElement( 'div' ) .
	Html::openElement( 'div', array( 'id' => 'p-insiders', 'class' => 'portal', 'role' => 'navigation' ) ) .
	Html::element( 'h3', array(), wfMessage( 'insider-title' )->text() ) .
	Html::openElement( 'div', array( 'class' => 'body' ) ) .
	Html::openElement( 'ul' ) ) .
	implode( '', $insiders );

In line 3 id was changed from p-lang to p-insiders because p-lang is already used. In the same line the role attribute was added.

In line 4 h3 must now noted instead of the former h5 (in current master correct).

Next to the last line the class="body" attribute was removed. No longer necessary.
Comment 1 RolandUnger 2013-07-24 05:43:11 UTC
Wrong id prevents Wikidata presenting "Languages" section
Comment 2 Gerrit Notification Bot 2013-07-25 14:32:09 UTC
Change 75877 had a related patch set uploaded by Aude:
(bug 51871) fix html for toolbox section

https://gerrit.wikimedia.org/r/75877
Comment 3 RolandUnger 2013-07-25 16:26:15 UTC
The next to the last line should be:

Html::openElement( 'ul', array() ) .
Comment 4 Gerrit Notification Bot 2013-07-26 16:47:38 UTC
Change 75877 merged by Hoo man:
(bug 51871) fix html for toolbox section

https://gerrit.wikimedia.org/r/75877
Comment 5 Lydia Pintscher 2013-09-23 10:21:25 UTC
This is merged now. Closing. Please reopen if it is still an issue.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links