Last modified: 2013-10-02 21:05:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53873, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 51873 - VisualEditor: Warning for blank reference list is confusing
VisualEditor: Warning for blank reference list is confusing
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Low enhancement
: VE-deploy-2013-10-03
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-23 11:59 UTC by John Mark Vandenberg
Modified: 2013-10-02 21:05 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description John Mark Vandenberg 2013-07-23 11:59:19 UTC
Removing the last reference on a page, with <references/> present, causes the waring:

There are no references with the group "" on this page.

That should be 

There are no references on this page.
Comment 1 James Forrester 2013-07-23 14:54:48 UTC
(In reply to comment #0)
> Removing the last reference on a page, with <references/> present, causes the
> waring:
> 
> There are no references with the group "" on this page.
> 
> That should be 
> 
> There are no references on this page.

No. You can have dozens of <ref group="foo">s and no <ref>s and get that message.

Perhaps a special-case of "There are no references without a group on this page." for the null-group instance?
Comment 2 John Mark Vandenberg 2013-07-23 20:53:46 UTC
In the use-case for this bug, there are no references of any group, so why mention groups at all.  IMO the UI shouldnt talk about groups unless it is necessary.  Most pages dont used grouped references.
Comment 3 Amir E. Aharoni 2013-07-26 07:19:51 UTC
I agree with John: Most pages dont used grouped references. It would be much more intuitive to say that there are no references at all. Several users in the Hebrew Wikipedia complained about it, and I imagine that it's the same in all languages.
Comment 4 Gerrit Notification Bot 2013-09-30 21:50:40 UTC
Change 86656 had a related patch set uploaded by Esanders:
Add specific message for empty ref group list

https://gerrit.wikimedia.org/r/86656
Comment 5 Gerrit Notification Bot 2013-10-02 21:05:09 UTC
Change 86656 merged by jenkins-bot:
Add specific message for empty ref group list

https://gerrit.wikimedia.org/r/86656

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links