Last modified: 2013-08-23 15:31:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53879, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 51879 - UploadWizard adding null location template and missing category
UploadWizard adding null location template and missing category
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UploadWizard (Other open bugs)
unspecified
All All
: High normal with 1 vote (vote)
: ---
Assigned To: Rainer Rillke @commons.wikimedia
https://commons.wikimedia.org/wiki/Co...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-23 13:12 UTC by Pi.1415926535
Modified: 2013-08-23 15:31 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Pi.1415926535 2013-07-23 13:12:57 UTC
UploadWizard on Commons is adding {{Location dec|0|0}} to all files - even when the "add location" link is not clicked on the form - and failing to add [[Category:Uploaded with UploadWizard]].
Comment 2 Rainer Rillke @commons.wikimedia 2013-07-24 11:39:50 UTC
I leave it to someone else, hovever, to apply mw's whitespace "conventions".
Comment 3 Rainer Rillke @commons.wikimedia 2013-07-24 12:56:33 UTC
4a530c4b7341b9bb8409b194469f594f24fb5548 seems to be the culprit by setting the default to "0".
Comment 4 Gerrit Notification Bot 2013-07-24 13:48:29 UTC
Change 75595 had a related patch set uploaded by Rillke:
Do not pre-fill longitude and latitude inputs with 0 values

https://gerrit.wikimedia.org/r/75595
Comment 5 Gerrit Notification Bot 2013-07-24 14:08:04 UTC
Change 75597 had a related patch set uploaded by Rillke:
Default value for lon and lat from 0 to empty String

https://gerrit.wikimedia.org/r/75597
Comment 6 Gerrit Notification Bot 2013-07-24 14:28:41 UTC
Change 75602 had a related patch set uploaded by Rillke:
Update CommonSettings to reflect changes in UpWiz

https://gerrit.wikimedia.org/r/75602
Comment 7 Gerrit Notification Bot 2013-07-24 15:19:52 UTC
Change 75602 merged by jenkins-bot:
Update CommonSettings to reflect changes in UpWiz

https://gerrit.wikimedia.org/r/75602
Comment 8 Gerrit Notification Bot 2013-07-25 08:08:04 UTC
Change 75597 merged by jenkins-bot:
Do not set default values for lat and lon

https://gerrit.wikimedia.org/r/75597
Comment 9 Rainer Rillke @commons.wikimedia 2013-07-25 13:18:02 UTC
For the community: I've filed a bot request at [[:commons:Commons:Bots/Requests/RillkeBot]] for cleaning this up.
Comment 10 Yuvi Panda 2013-07-25 13:23:49 UTC
Thanks Rillke :)
Comment 11 Gerrit Notification Bot 2013-07-29 18:39:12 UTC
Change 75595 merged by jenkins-bot:
Clean-up UploadWizardDetails.js

https://gerrit.wikimedia.org/r/75595
Comment 12 Rainer Rillke @commons.wikimedia 2013-07-29 22:54:19 UTC
Thanks for the code-review. Everything that removed the symptoms (except in upload wizard campaigns that had set their config of lat and lon to 0) is already live.
Comment 13 herzi.pinki 2013-08-02 13:58:30 UTC
I do not think that it is fixed:
see e.g. http://commons.wikimedia.org/w/index.php?title=File:Feldkirch_Johannitergasse_6.jpg&oldid=101087802

Still there is
* {{Location dec|0|0}}
* and additionally: <strong class="error">Expression error: Unrecognized punctuation character &quot;&quot;.</strong>

if there are exif coords (http://commons.wikimedia.org/w/index.php?title=File:Postmeilenstein_Neudorf_ob_Wildon_20130726.jpg&oldid=101119356) there is as a new effect:
<strong class="error">Expression error: Unrecognized punctuation character &quot;&quot;.</strong>
Comment 14 Rainer Rillke @commons.wikimedia 2013-08-02 15:46:29 UTC
https://commons.wikimedia.org/wiki/Campaign:wlm-at sets 
lat	0
lon	0
by default. This was fixed by 268ea6bc599bbe26ef58b89695402f9d506def29 which is not live, yet. The issue only occurs with campaign uploads if the campaign sets 0-defaults.

The error message comes from 
{{subst:WLM-is-running|at|{{Wiki Loves Monuments 2013|at}}}}
which is something to be fixed at Commons.
Comment 15 Rainer Rillke @commons.wikimedia 2013-08-02 15:50:36 UTC
I left a comment at https://commons.wikimedia.org/wiki/Campaign_talk:wlm-at
Comment 16 Rob Lanphier 2013-08-22 21:18:34 UTC
Is this still an issue?  We'll mark this resolved next time we touch this unless we see information to the contrary.
Comment 17 Mark Holmquist 2013-08-22 21:19:59 UTC
It looks like it is resolved per https://commons.wikimedia.org/w/index.php?title=File:Oban_-_McCaig%27s_Tower_1.JPG&action=edit
Comment 18 herzi.pinki 2013-08-22 21:22:25 UTC
(In reply to comment #16)
> Is this still an issue?  We'll mark this resolved next time we touch this
> unless we see information to the contrary.

I do not see any issue at the moment. You can fix it. Thanks for caring.
Comment 19 herzi.pinki 2013-08-22 21:23:32 UTC
(In reply to comment #18)
> (In reply to comment #16)
> > Is this still an issue?  We'll mark this resolved next time we touch this
> > unless we see information to the contrary.
> 
> I do not see any issue at the moment. You can fix it. Thanks for caring.

You can close it, of course.
Comment 20 Rainer Rillke @commons.wikimedia 2013-08-23 15:31:04 UTC
(In reply to comment #17)
That is not a representative example. I as waiting for https://gerrit.wikimedia.org/r/#/c/75595/ to go live so zero-templates through upload campaigns are also avoided.

It apparently is now.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links