Last modified: 2013-10-02 20:49:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53893, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 51893 - VisualEditor: Page content not rendered after unclosed <center> tag in image caption of non-thumbnails
VisualEditor: Page content not rendered after unclosed <center> tag in image...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: ssastry
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-23 16:59 UTC by Chris McKenna
Modified: 2013-10-02 20:49 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Chris McKenna 2013-07-23 16:59:51 UTC
When an image file is included directly in an article (i.e not as a thumbnail and not in a frame) with an unclosed <center> tag in the caption causes Visual Editor to not render any page content after the image.

See https://en.wikipedia.org/w/index.php?title=User:Thryduulf/sandbox2&oldid=565498603 for an example.

All the following conditions must be true to see this bug:
* Image must not be a thumbnail or in a frame
* The image caption must contain an unclosed html tag specifying text alignment in the caption. Tested with <center>, <p align="center"> and <div align="right">
* The image placement (left, right or center) must be specified

The bug does not occur with an unclosed italic html tag. I haven't tested with other tags.
Comment 1 Chris McKenna 2013-07-23 17:03:44 UTC
Forgot to note that although this combination of conditions is presumably uncommon, it was first observed in the wild at https://en.wikipedia.org/w/index.php?title=Typographer_%28typewriter%29&oldid=565431177
Comment 2 ssastry 2013-10-02 20:26:33 UTC
Unclosed tags in image caption is not that infrequent unfortunately -- the difference between <center> and <i>/<b> tags is that the former is a block tag and the latter is an inline tag. So, any other block tag that is unclosed will cause the same issue. 

That said, I am surprised that this problem showed up in the first place since Parsoid has had support to deal with unbalanced tags for a long time: https://gerrit.wikimedia.org/r/#/c/43384/

This was a bit of a hacky support. More robust and improved support for this is coming in https://gerrit.wikimedia.org/r/#/c/83216/

So, unsure what happened here with this bug.
Comment 3 James Forrester 2013-10-02 20:33:33 UTC
Will provisionally mark this as in-review, then (you can see that it's still happening with production Parsoid, though that may be cache errors).
Comment 4 ssastry 2013-10-02 20:49:02 UTC
As we discussed and confirmed on IRC, this is not happening in production right now. So, I am going to mark this resolved-fixed. Please reopen if a similar error shows up.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links