Last modified: 2014-03-01 12:40:26 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53922, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 51922 - VisualEditor: Multicol/BeginKolommen/Colonne and wikitext leaking into VE
VisualEditor: Multicol/BeginKolommen/Colonne and wikitext leaking into VE
Status: NEW
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Editing team bugs – take if you're interested!
:
Depends on:
Blocks: ve-nonenglish
  Show dependency treegraph
 
Reported: 2013-07-24 03:54 UTC by John Mark Vandenberg
Modified: 2014-03-01 12:40 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Wikitext appearing in transclusion dialog (167.95 KB, image/png)
2013-07-24 03:54 UTC, John Mark Vandenberg
Details

Description John Mark Vandenberg 2013-07-24 03:54:04 UTC
Created attachment 12938 [details]
Wikitext appearing in transclusion dialog

The underlying cause of this might be covered in bug 48231 or bug 51217 or others ... I thought I saw a bug about this, but cant find it now.

[[template:multicol]] with wikisyntax inside it results in the attached screenshot, with wikitext visible in the transclusion dialog as 'Content' blocks.

https://nl.wikipedia.org/wiki/Gebruiker:John_Vandenberg/test?veaction=edit

Section headers & list items also cause this; see the last block here:
https://en.wikipedia.org/w/index.php?title=User:John_Vandenberg/test&oldid=565567699&veaction=edit

If it helps, this issue is present on one of the parsoid topfails:

https://nl.wikipedia.org/wiki/Eerste_divisie_1996/97?veaction=edit

BeginKolommen occurs on nlwp 3047 times.  11362 times in enwp.  8861 times in eswp. 40985 times on itwp!, which is roughly 4% of the content pages.

Confirmed this is happening on every itwp invocation that I edit
https://it.wikipedia.org/wiki/Speciale:PuntanoQui/Template:Colonne
e.g.
https://it.wikipedia.org/wiki/Aeroplano?veaction=edit
Comment 1 John Mark Vandenberg 2013-07-24 04:06:46 UTC
Editing the wikitext appears to function correctly, which is good news.
https://it.wikipedia.org/w/index.php?title=Matematica&diff=60342095&oldid=59678552
Comment 2 Roan Kattouw 2013-07-24 04:10:24 UTC
{{BeginKolommen}} generates the beginning of a table, and {{EindeKolommen}} generates the end of that table. All content between those two is treated as one template call. This is expected behavior in the current implementation, and is exactly the same as succession boxes and all other templates that generate openings and closings separately (multipart templates).

It would be nice if we could let users edit these in a nicer way, especially considering that some (but not all) of the wikitext blocks are actually innocuous wikitext that VE could reasonably edit, but right now we can't. This is part of the reason why multipart templates suck.

What is the Parsoid topfail thing you're talking about? There's no link to the failure and it seems unrelated to this issue.


Not closing this as INVALID or whatever because this is something we should actually handle better.
Comment 3 John Mark Vandenberg 2013-07-24 04:15:58 UTC
I think it is impressive that VE handles it

'nl:Eerste divisie 1996/97' is on the parsoid topfails list

http://parsoid.wmflabs.org:8001/topfails

Here is an itwp example where multicol consumes most of the page, and should probably be removed.

https://it.wikipedia.org/wiki/Campagna_%28comune%29?veaction=edit
Comment 4 Roan Kattouw 2013-07-24 04:30:08 UTC
(In reply to comment #3)
> I think it is impressive that VE handles it
> 
This is mostly thanks to Parsoid handling this case very well, and VE simply building a UI around it :)

> 'nl:Eerste divisie 1996/97' is on the parsoid topfails list
> 
> http://parsoid.wmflabs.org:8001/topfails
> 
Oh, I see. It's not any more now :(

> Here is an itwp example where multicol consumes most of the page, and should
> probably be removed.
> 
> https://it.wikipedia.org/wiki/Campagna_%28comune%29?veaction=edit
Yes. I just fixed that page.
Comment 5 John Mark Vandenberg 2013-07-24 04:36:54 UTC
(In reply to comment #4)
> > 'nl:Eerste divisie 1996/97' is on the parsoid topfails list
> > 
> > http://parsoid.wmflabs.org:8001/topfails
> > 
> Oh, I see. It's not any more now :(

It is on page two of 16

http://parsoid.wmflabs.org:8001/topfails/2

I have no idea if the {{BeginKolommen}} or tables within it have anything to do with the semantic failure; just thought I should mention it.
Comment 6 Roan Kattouw 2013-07-24 04:41:38 UTC
(In reply to comment #5)
> (In reply to comment #4)
> > > 'nl:Eerste divisie 1996/97' is on the parsoid topfails list
> > > 
> > > http://parsoid.wmflabs.org:8001/topfails
> > > 
> > Oh, I see. It's not any more now :(
> 
> It is on page two of 16
> 
> http://parsoid.wmflabs.org:8001/topfails/2
> 
Aha! Found it.

> I have no idea if the {{BeginKolommen}} or tables within it have anything to
> do
> with the semantic failure; just thought I should mention it.
That doesn't appear to be the case: looking at the RT diff (which you get to by clicking on the page name), it's mostly related to the tables on the page: http://parsoid.wmflabs.org/_rt/nl/Eerste_divisie_1996/97

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links