Last modified: 2013-08-26 16:27:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53948, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 51948 - VisualEditor: A <nowiki> on page causes "Uncaught RangeError: Maximum call stack size exceeded" in oojs.compare
VisualEditor: A <nowiki> on page causes "Uncaught RangeError: Maximum call st...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Data Model (Other open bugs)
unspecified
All All
: Highest major
: VE-deploy-2013-08-15
Assigned To: Roan Kattouw
:
Depends on:
Blocks: 51950
  Show dependency treegraph
 
Reported: 2013-07-24 10:17 UTC by Amir E. Aharoni
Modified: 2013-08-26 16:27 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Amir E. Aharoni 2013-07-24 10:17:29 UTC

    
Comment 1 Amir E. Aharoni 2013-07-24 10:23:57 UTC
[Sorry, somehow it was created without a description.]

On the latest master I cannot edit a page that has <nowiki> in it. VisualEditor appears to be loading with the "progress bar", but doesn't go to actual editing mode.

Versions:
VisualEditor 393807462e9d04ec5e437cb50ef1d03e5644e9be
Parsoid be8a7dea49bd70692ef574a1bb7c7a70584d77e3
core e617dc6c8f2ce1d867ddadcd4bc3de098a84ff07
Comment 2 Gerrit Notification Bot 2013-07-24 16:21:27 UTC
Change 75636 had a related patch set uploaded by Jforrester:
Put <nowiki> edting in experimental for now

https://gerrit.wikimedia.org/r/75636
Comment 3 Gerrit Notification Bot 2013-07-24 16:25:03 UTC
Change 75636 merged by jenkins-bot:
Put <nowiki> edting in experimental for now

https://gerrit.wikimedia.org/r/75636
Comment 4 MZMcBride 2013-07-25 05:27:07 UTC
https://www.mediawiki.org/w/index.php?title=Extension:MassMessage/Design&oldid=745378&veaction=edit

When I go to this URL in Google Chrome/OS X/Version 27.0.1453.116, I get the following error in my JavaScript console:

Uncaught RangeError: Maximum call stack size exceeded
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
oo.compare
Comment 5 James Forrester 2013-07-26 00:00:13 UTC
(In reply to comment #4)
> https://www.mediawiki.org/w/index.php?title=Extension:MassMessage/
> Design&oldid=745378&veaction=edit
> 
> When I go to this URL in Google Chrome/OS X/Version 27.0.1453.116, I get the
> following error in my JavaScript console:
> 
> Uncaught RangeError: Maximum call stack size exceeded
> oo.compare
> oo.compare
[…]

This is now masked by some significant performance improvements we made (so it "works"), but we think it's still an issue; keeping open.
Comment 6 Gerrit Notification Bot 2013-07-27 00:10:10 UTC
Change 76220 had a related patch set uploaded by Jforrester:
Don't compare annotations directly with ve.compare()

https://gerrit.wikimedia.org/r/76220
Comment 7 Gerrit Notification Bot 2013-07-29 19:47:28 UTC
Change 76220 merged by jenkins-bot:
Don't compare annotations directly with ve.compare()

https://gerrit.wikimedia.org/r/76220
Comment 8 James Forrester 2013-07-29 23:05:13 UTC
Now fixed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links