Last modified: 2013-08-16 20:05:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53963, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 51963 - File with empty |link= parameter becomes undefined .. nullxnullpx
File with empty |link= parameter becomes undefined .. nullxnullpx
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Data Model (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2013-08-22
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-24 13:06 UTC by Waihorace
Modified: 2013-08-16 20:05 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Waihorace 2013-07-24 13:06:32 UTC
https://zh.wikipedia.org/?diff=27825404&oldid=26993245

A use tried to edit a template, but when he/she save his/her edit, it also break the image below which he/she haven't edit and it change the image into undefined.
Comment 1 John Mark Vandenberg 2013-07-24 22:44:50 UTC
I was able to reproduce this bug altering the template under the text '维基数据'.

The media link changes without the user being involved.

https://zh.wikipedia.org/w/index.php?title=User:John_Vandenberg/MainPage&action=history
Comment 2 John Mark Vandenberg 2013-07-25 12:18:05 UTC
A simple test case

'.
[[File:Wikimedia-logo.svg|45px|center|link=]]'

change '.' to '..' and save.

or
https://en.wikipedia.org/w/index.php?title=User:John_Vandenberg/test&oldid=565743208&veaction=edit

Results:
1. Image disappears
2. Saving changes the result to:

'..
[[undefined|center|link=|nullxnullpx]]
'
Comment 4 Gabriel Wicke 2013-08-13 23:06:57 UTC
The following round-trips fine at http://parsoid.wmflabs.org/_rtform/:

[[File:Wiki.png|45px|center|link=]]

This makes it likely that this is actually a VE issue. Moving to the VE component for investigation.
Comment 5 Gerrit Notification Bot 2013-08-15 19:38:38 UTC
Change 79256 had a related patch set uploaded by Esanders:
Fix traversal for images with link=''

https://gerrit.wikimedia.org/r/79256
Comment 6 Gerrit Notification Bot 2013-08-16 01:24:53 UTC
Change 79256 merged by jenkins-bot:
Fix traversal for images with link=''

https://gerrit.wikimedia.org/r/79256
Comment 7 James Forrester 2013-08-16 02:20:37 UTC
This is now fixed in master (but images with link= will trigger a VE corruption warning - to be fixed tomorrow). It should be pushed to production in the next few days.
Comment 8 Gerrit Notification Bot 2013-08-16 19:07:02 UTC
Change 79355 had a related patch set uploaded by Esanders:
Build link-less images with <span> not <a>

https://gerrit.wikimedia.org/r/79355
Comment 9 Gerrit Notification Bot 2013-08-16 19:16:06 UTC
Change 79355 merged by jenkins-bot:
Build link-less images with <span> not <a>

https://gerrit.wikimedia.org/r/79355

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links