Last modified: 2013-11-07 18:25:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53987, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 51987 - VisualEditor: Infinite loop (browser lockup) when removing an initial list item with a node inside it (rangy bug?)
VisualEditor: Infinite loop (browser lockup) when removing an initial list it...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: High normal
: ---
Assigned To: Inez Korczyński
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-24 19:53 UTC by Excirial
Modified: 2013-11-07 18:25 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Firefox - Detected script lockup. (15.02 KB, image/png)
2013-07-24 19:53 UTC, Excirial
Details

Description Excirial 2013-07-24 19:53:47 UTC
Created attachment 12947 [details]
Firefox - Detected script lockup.

Misplacing a bulleted / numbered list can cause a script lockup. Tested on both Firefox 22 and Chrome 28

Steps to reproduce:
- Navigate to [[Lauda Air Flight 004]] and open it with the visual editor.
- Click the "Lauda Air Flight 004" infobox and make sure it remains selected.
- Click the "Bulleted List" button. A list bullet is added to the article.
- Click right after the bullet that was just inserted. Now click the "Bulleted list" button again.

Normally this would remove the bullet again. Instead of that both Firefox and Chrome seem to lock up. Firefox will lock up entirely (All open tabs will freeze) and eventually an unresponsive script error will be displayed. Cancelling the script allows you to regain browser control. On Chrome the lockup seems isolated to the tab where we edit Wikipedia, but it only offers the option to close the tab after a while (Losing all changes)

In practice one would never want to add a bulleted list this way, but actually "crashing" makes it severe enough to report i would assume.
Comment 1 John Mark Vandenberg 2013-09-30 09:51:18 UTC
We should have a 'crash' or 'dataloss' keyword.  Bumping priority to get more attention/triaging in case the underlying cause is able to be triggered in other ways.
Comment 2 James Forrester 2013-10-03 21:43:52 UTC
This is an infinite loop inside either Rangy or the bit of ContentEditable that calls it - lots of calls to sel.getRangeAt(index) which end up taking so long that the browser dies (?)
Comment 3 Rummana Yasmeen 2013-11-07 00:56:40 UTC
Cannot reproduce it now with MAC OS using FireFox and Chrome.So changing the status of the bug as resolved.
If you can still reproduce it ,please reopen the bug.
Comment 4 Andre Klapper 2013-11-07 08:38:45 UTC
(In reply to comment #3)
> Cannot reproduce it now with MAC OS using FireFox and Chrome.

Please ALWAYS provide version information for browsers. 
Note that comment 0 says "Tested on both Firefox 22 and Chrome 28".

> So changing the status of the bug as resolved.

No identifiable code commit, hence changing to WORKSFORME instead of FIXED. Also see https://www.mediawiki.org/wiki/Bug_management/Bug_report_life_cycle
Comment 5 James Forrester 2013-11-07 18:25:23 UTC
Resetting to FIXED; this was a confirmed broken behaviour which has subsequently been FIXED, as far as we can tell - probably by the re-write of the Content Editable surface interaction model.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links