Last modified: 2014-02-12 23:55:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53991, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 51991 - Formatter: MobileFormatter doesn't wrap sections correctly
Formatter: MobileFormatter doesn't wrap sections correctly
Status: RESOLVED DUPLICATE of bug 55521
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-24 21:24 UTC by Juliusz Gonera
Modified: 2014-02-12 23:55 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Juliusz Gonera 2013-07-24 21:24:33 UTC
See https://es.m.wikipedia.org/wiki/Wikipedia:Caf%C3%A9/Archivo/T%C3%A9cnica/Actual

(this revision if it changed since reported: https://es.m.wikipedia.org/w/index.php?title=Wikipedia:Caf%C3%A9/Archivo/T%C3%A9cnica/Actual&oldid=68583002)

Even though the section "Crear mapas interactivos" is folded I can still see text below it because it is not wrapped in div.content_block.
Comment 1 Jon 2013-09-17 22:46:26 UTC
Looks like this might have been caused by bad template HTML...
Comment 2 Jon 2013-09-24 22:37:22 UTC
Is this a bug we should spend time on? On the one hand it's worrying an editor can create bad HTML that breaks the mobile site rendering, on the other hand it's good to showcase things that are broken so they get fixed...
Comment 3 Max Semenik 2013-10-02 19:31:47 UTC
Can't reproduce anymore, appears to have been fixed by our recent formatting overhaul.
Comment 4 Jon 2013-10-05 03:44:27 UTC
As stated above it wasn't fixed by the overhaul but it seems to hint at unclosed DIV's generated by templates.... That said I'm not sure what we do here expect fix tidy... just wanted to point out it was NOT fixed by formatting overhaul - I can still replicate it.
Comment 5 Jon 2013-10-09 17:27:02 UTC
*** Bug 55521 has been marked as a duplicate of this bug. ***
Comment 6 Jon 2013-10-09 17:27:44 UTC
Max looks like we can duplicate this again:
On the mobile site for commons: https://commons.m.wikimedia.org/wiki/Commons:VP
has weird section collapsing. It has a whole bunch of sections grouped under
"September 24" (Like "October 08") even though they should be the same level as
"September 24"
Comment 7 Max Semenik 2013-10-15 19:52:58 UTC
Repro for this: https://commons.m.wikimedia.org/w/index.php?title=User:MaxSem/sandbox&oldid=107160980

The section formatter going berserk appears to be caused by an unclosed <div> at the end of September 24 section.
Comment 8 Jon 2013-10-15 19:58:54 UTC
The ability to produce bad HTML seems very bad. Would it be feasible/controversial for the parser to notice this behaviour and close them when it reaches the end of the article / a section heading?
Comment 9 Max Semenik 2013-10-15 22:47:23 UTC
It's not a bad HTML neither from validator's POV, nor from parser's nor from end-user's - it's just our section wrapping that doesn't like it.
Comment 10 Jon 2013-10-30 15:01:59 UTC

*** This bug has been marked as a duplicate of bug 55521 ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links