Last modified: 2014-11-03 19:47:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54008, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 52008 - VisualEditor: Gracefully handle when available browser UI features are disabled (rather than refusing to load)
VisualEditor: Gracefully handle when available browser UI features are disabl...
Status: ASSIGNED
Product: VisualEditor
Classification: Unclassified
Initialisation (Other open bugs)
unspecified
All All
: Low enhancement
: ---
Assigned To: Editing team bugs – take if you're interested!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-25 00:45 UTC by John Mark Vandenberg
Modified: 2014-11-03 19:47 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description John Mark Vandenberg 2013-07-25 00:45:06 UTC
VE should work as expected without clipboard access.  Currently it only half initalises.

1. Install Kill Evil in Chrome or similar
2. Edit any page

(https://chrome.google.com/webstore/detail/kill-evil/epieehnpcepgfiildhdklacomihpoldk)

Result:
https://en.wikipedia.org/wiki/File:Missing-ui-ve.png
Comment 1 Bartosz Dziewoński 2013-07-25 00:52:36 UTC
That's more likely caused by the "getSelection and onselectstart/onmousedown" part of that extension.
Comment 2 John Mark Vandenberg 2013-07-25 01:03:10 UTC
That too ;-)  Making the bug more general.  Hopefully VE is able to be at least partially functional without all those fancy things.
Comment 3 Bartosz Dziewoński 2013-07-25 01:15:07 UTC
This isn't a fancy thing. You can't do things like bold the selection if you can't access information about what is actually selected.
Comment 4 John Mark Vandenberg 2013-07-25 04:54:07 UTC
When 'Kill Evil' addon exists, there are two failures to load modules, and then an exception which halts the VE initialisation half way.

Module 'WrappedSelection' failed to load: Module 'WrappedSelection' failed to load: No means of selecting a Range or TextRange was found rangy-core-1.3.js:105

Module 'Position' failed to load: required module 'WrappedSelection' not supported rangy-core-1.3.js:105

Uncaught TypeError: Object #<WrappedSelection> has no method 'refresh' rangy-core-1.3.js:3035

WrappedSelection rangy-core-1.3.js:3035
getSelection rangy-core-1.3.js:3084
ve.ce.Surface.showSelection ve.ce.Surface.js:1325
ve.ce.Surface.onChange ve.ce.Surface.js:747
oo.EventEmitter.emit oo.js:421
ve.dm.Surface.change ve.dm.Surface.js:402
ve.dm.SurfaceFragment.select ve.dm.SurfaceFragment.js:448
ve.ui.Surface.initialize ve.ui.Surface.js:81
(anonymous function) ve.init.mw.ViewPageTarget.js:1098
proxy load.php?debug=true&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.t…%7Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20130725T023359Z:775

in ve.ui.Surface method initialize, the following invocation should probably be skipped if those rangy modules have failed to load.

   // By re-asserting the current selection and forcing a poll we force selection to be something
   // reasonable - otherwise in Firefox, the initial selection is (0,0), causing bug 42277
   this.model.getFragment().select();
Comment 5 James Forrester 2014-01-22 18:58:59 UTC
Sorry for very slow triage.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links