Last modified: 2014-10-06 10:17:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54011, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 52011 - VisualEditor: ve.ui.Context#toolbar is null in MediaWiki
VisualEditor: ve.ui.Context#toolbar is null in MediaWiki
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Technical Debt (Other open bugs)
unspecified
All All
: Normal enhancement
: ---
Assigned To: Editing team bugs – take if you're interested!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-25 01:41 UTC by Krinkle
Modified: 2014-10-06 10:17 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2013-07-25 01:41:38 UTC
Following the documentation[1] starting at ve.ui.Surface (from ve.instances[0]) one would go to #getContext and access .toolbar. But though that property is defined, it is set to null.

I'm not sure why, but apparently our MediaWiki's init is instantiating its own and is only accessible from ve.init.mw.ViewPageTarget#toolbar (ve.init.mw.targets[0].toolbar).

It probably shouldn't have to instantiate its own one, and certainly not make it inaccessible to the rest of VE.


[1] https://doc.wikimedia.org/VisualEditor/master/#!/api/ve.ui.Surface
Comment 1 Roan Kattouw 2014-10-06 10:17:02 UTC
There used to be a .toolbar property because the context had its own (local) toolbar to show the contextual tools in. This has been replaced with ContextWidget (which isn't a toolbar) which groups ContextItemWidget (which aren't tools), and now there is no .toolbar property.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links