Last modified: 2013-07-25 23:10:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54012, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 52012 - Typing plain text into a large page is very slow
Typing plain text into a large page is very slow
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Data Model (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2013-07-25
Assigned To: Ed Sanders
:
Depends on:
Blocks: ve-performance
  Show dependency tree / graph
 
Reported: 2013-07-25 04:59 UTC by Tim Starling
Modified: 2013-07-25 23:10 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Tim Starling 2013-07-25 04:59:25 UTC 
On [[Argentina]] on Firefox on my laptop, typing plain text takes about 380ms per character, assuming I am interpreting the profiling correctly, meaning you can type faster than it can update.

This is predominantly because ve.dm.Surface.prototype.change() calls truncateUndoStack(), which unconditionally sends the "history" event despite there normally being no changes to the redo buffer. The history event causes ResizableNode and RelocatableNode instances to perform several jQuery.css() calls, which apparently are very slow.

I confirmed that disabling truncateUndoStack() using the JS console causes typing to become much faster.
Comment 1 Gerrit Notification Bot 2013-07-25 13:37:05 UTC 
Change 75863 had a related patch set uploaded by Esanders:
Optimise history stack truncation

https://gerrit.wikimedia.org/r/75863
Comment 2 Gerrit Notification Bot 2013-07-25 22:11:32 UTC 
Change 75863 merged by jenkins-bot:
Optimise history stack truncation

https://gerrit.wikimedia.org/r/75863
Comment 3 James Forrester 2013-07-25 23:10:42 UTC 
Now fixed in master and will be deployed in a few minutes' time.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links