Last modified: 2014-03-30 07:38:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54027, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 52027 - UnknownAction hook not mentioned as deprecated in Wiki.php


Summary:	UnknownAction hook not mentioned as deprecated in Wiki.php

Status:	PATCH_TO_REVIEW

Product:	MediaWiki
Classification:	Unclassified
Component:	Documentation (Other open bugs)
Version:	1.22.0
Hardware:	All All

Importance:	Low trivial (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:	easy

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-07-25 14:03 UTC by Zell Faze
Modified:	2014-03-30 07:38 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Commented accordingly (757 bytes, patch) 2014-01-20 16:30 UTC, Ankur	Details
Add an attachment (proposed patch, testcase, etc.)

Description Zell Faze 2013-07-25 14:03:07 UTC

r86041 Deprecated the UnknownAction hook in Wiki.php.  This is documented in Action.php.

There is no mention of the deprecation in Wiki.php which is the first place that I think most people would look for the deprecation notice.

Comment 1 Vishnu Nk 2014-01-02 16:50:02 UTC

Can you please give me a brief about how to fix this.Im new to this and I would Like to work on this Sir.

Comment 2 Andre Klapper 2014-01-02 20:35:56 UTC

Vishnu Nk: If I was you I'd look for other deprecated stuff in the codebase and how it is marked as deprecated.

Comment 3 Ankur 2014-01-20 16:30:18 UTC

Created attachment 14349 [details]
Commented accordingly

Comment 4 PiRSquared17 2014-03-09 03:17:08 UTC

(In reply to Ankur from comment #3)
> Created attachment 14349 [details]
> Commented accordingly

Are you going to commit it?

Comment 5 Andre Klapper 2014-03-09 10:55:09 UTC

The comment does not clearly mention *what* is deprecated, "update with" is unclear in the patch summary, there is a typo ("depreceted"), and the patch should go into Gerrit: https://www.mediawiki.org/wiki/Developer_access

Comment 6 Gerrit Notification Bot 2014-03-30 07:38:42 UTC

Change 122098 had a related patch set uploaded by Rahul mishra:
UnknownAction hook not mentioned as deprecated in Wiki.php

https://gerrit.wikimedia.org/r/122098

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links