Last modified: 2013-08-01 10:00:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54039, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 52039 - handle Wikibase initialization order and settings without throwing exception
handle Wikibase initialization order and settings without throwing exception
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
master
All All
: Highest critical (vote)
: ---
Assigned To: Wikidata bugs
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-25 17:19 UTC by Aude
Modified: 2013-08-01 10:00 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Aude 2013-07-25 17:19:54 UTC
We cannot enforce Wikibase initialization order by throwing an exception if wrong.  It's waaaaaaaay too fragile and interferes with production.

We *must* come up with another way to handle any issues in wikibase that occur with incorrect initialization order.
Comment 1 Daniel Kinzler 2013-07-25 21:44:47 UTC
The issue is "magic" defaults: when client and repo are active on the same wiki, some client settings should default to values from the repo settings. For that to work, the repo must be initialized when the defaults are applied.

So, if we don't want to depend on the order of inclusion in LocalSettings, we have to defer the evaluation of defaults.

One idea I toyed with a while ago is to allow closures as default values, which would automatically get evaluated when the setting is used the first time. This way, the default could depend on other extensions without enforcing the order of inclusion/configuration.
Comment 2 Gerrit Notification Bot 2013-07-26 14:26:23 UTC
Change 76099 had a related patch set uploaded by Daniel Kinzler:
(bug 52039) Use closures for dynamic defaults.

https://gerrit.wikimedia.org/r/76099
Comment 3 Gerrit Notification Bot 2013-07-29 12:14:11 UTC
Change 76099 merged by jenkins-bot:
(bug 52039) Use closures for dynamic defaults.

https://gerrit.wikimedia.org/r/76099
Comment 4 abraham.taherivand 2013-08-01 10:00:14 UTC
Verified in Wikidata demo July 31th.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links