Last modified: 2014-02-26 12:55:32 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54054, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 52054 - EventLogging: Schema samples dialog doesn't handle overflow
EventLogging: Schema samples dialog doesn't handle overflow
Status: RESOLVED FIXED
Product: Analytics
Classification: Unclassified
EventLogging (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Ori Livneh
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-25 20:39 UTC by Krinkle
Modified: 2014-02-26 12:55 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot of schema sample dialog on [[m:Schema:MobileWatchlistInteraction]] (120.46 KB, image/png)
2013-07-25 20:39 UTC, Krinkle
Details

Description Krinkle 2013-07-25 20:39:54 UTC
Created attachment 12959 [details]
Screenshot of schema sample dialog on [[m:Schema:MobileWatchlistInteraction]]

The dialog seems to have a fixed width (30em) and no overflow handling, so the text just overflows out of the bounding box. Should probably allow some extension (min-width, max-width?) and perhaps scroll otherwise (overflow-x: auto).
Comment 1 Krinkle 2013-07-25 20:51:26 UTC
Minor things:
* Red button doesn't have a tooltip
* Shadow seems a bit excessive
* Dialog could do with a subtle border
* Perhaps not use a border radius

Quick hack (use as you see fit): background: #fff; border: 1px solid #ddd; box-shadow: rgba(0, 0, 0, 0.3) 0.3em 0.3em 1em; border-radius: 0;
Comment 2 Ori Livneh 2013-07-25 20:54:56 UTC
Krinkle, you're awesome :) Thanks. I'll give that a shot.
Comment 3 Gerrit Notification Bot 2013-09-16 06:59:46 UTC
Change 84296 had a related patch set uploaded by Ori.livneh:
Improve styling of schema code samples dialog

https://gerrit.wikimedia.org/r/84296
Comment 4 Gerrit Notification Bot 2013-09-17 06:48:43 UTC
Change 84296 merged by jenkins-bot:
Improve styling of schema code samples dialog

https://gerrit.wikimedia.org/r/84296
Comment 5 Andre Klapper 2014-02-26 12:55:32 UTC
[moving from MediaWiki extensions to Analytics product - see bug 61946]

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links