Last modified: 2013-07-25 21:24:47 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54057, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 52057 - UploadBlacklist needs a comment tweak


Summary:	UploadBlacklist needs a comment tweak

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	Other (Other open bugs)
Version:	master
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	---
Assigned To:	Kunal Mehta (Legoktm)

URL:
Whiteboard:
Keywords:	easy

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-07-25 21:20 UTC by MZMcBride
Modified:	2013-07-25 21:24 UTC (History)
CC List:	2 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description MZMcBride 2013-07-25 21:20:04 UTC

From <https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FUploadBlacklist.git/e996b431806a6bf6e045a3dccd642b0e28cbb127/UploadBlacklist.php>:

---
 * Callback for UploadVerification hook; calculates the file's
 * MD5 hash and checks it against a list of blacklisted files.
 * If it matches, the upload will be denied.
---

---
$hash = sha1_file( $tempName );
---

The comment is wrong/outdated.

Comment 1 Gerrit Notification Bot 2013-07-25 21:22:53 UTC

Change 76010 had a related patch set uploaded by Legoktm:
UploadBlacklist uses sha1 hash, not md5

https://gerrit.wikimedia.org/r/76010

Comment 2 Gerrit Notification Bot 2013-07-25 21:24:08 UTC

Change 76010 merged by jenkins-bot:
UploadBlacklist uses sha1 hash, not md5

https://gerrit.wikimedia.org/r/76010

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links