Last modified: 2013-07-31 21:25:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54103, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 52103 - Missing nowiki escaping when single quotes wrap new i/b tags
Missing nowiki escaping when single quotes wrap new i/b tags
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
serializer (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-26 16:55 UTC by ssastry
Modified: 2013-07-31 21:25 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description ssastry 2013-07-26 16:55:16 UTC
Reported at: https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback#Link_formatting_trick

Simplified test cases here:

[subbu@earth lib] echo "[[Foo|'foo']]" | node parse | sed "s/foo/<i>foo<\/i>/g;" | node parse --html2wt
[[Foo|'''foo''']]

[subbu@earth lib] echo "[[Foo|'foo']]" | node parse | sed "s/foo/<b>foo<\/b>/g;" | node parse --html2wt
[[Foo|''''foo'''']]
Comment 1 Gerrit Notification Bot 2013-07-26 20:36:25 UTC
Change 76162 had a related patch set uploaded by Subramanya Sastry:
(Bug 52103) <nowiki/> escape when single quotes wrap new i/b tags

https://gerrit.wikimedia.org/r/76162
Comment 2 Gerrit Notification Bot 2013-07-27 17:32:58 UTC
Change 76162 merged by jenkins-bot:
(Bug 52103) <nowiki/> escape when single quotes wrap new i/b tags

https://gerrit.wikimedia.org/r/76162
Comment 3 Gerrit Notification Bot 2013-07-29 04:04:27 UTC
Change 76467 had a related patch set uploaded by Subramanya Sastry:
Take #2: (Bug 52103) nowiki escaping when quotes surround i/b tags

https://gerrit.wikimedia.org/r/76467
Comment 4 Gerrit Notification Bot 2013-07-29 14:31:58 UTC
Change 76467 merged by jenkins-bot:
Take #2: (Bug 52103) nowiki escaping when quotes surround i/b tags

https://gerrit.wikimedia.org/r/76467
Comment 5 ssastry 2013-07-31 21:25:13 UTC
Deployed and tested in production.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links