Last modified: 2013-08-16 03:09:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54113, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 52113 - VisualEditor: Undo keyboard shortcuts clear undo / redo history if pressed too often (And other fun)
VisualEditor: Undo keyboard shortcuts clear undo / redo history if pressed to...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2013-08-22
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-26 20:17 UTC by Excirial
Modified: 2013-08-16 03:09 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Excirial 2013-07-26 20:17:01 UTC
Tested on Firefox 22 (Monobook) and Chrome 28 (Vector)

Steps to reproduce:
- Open any random page in the visual editor. Personally i used [[Botnet]].
- Add the word "Test" to the page.
- Press Ctrl + Z to undo the edit. Keep pressing till the edit is gone, then press it once more.

Once you have done this, the Redo button and the Redo shortcut (Ctrl+Shift+Z) no longer seem to restore the previous edits. Any subsequent edit seems to reset the undo / redo buttons to an "There were no previous edits" state.

Inconsistent results:

Besides the above result that i can always reproduce using these steps, i have seen various other results. I have seen each of these at least twice but no matter what i try, i cannot seem to find any method of reproducing these reliably.

- An entry in the console log stating "Error: Cannot roll back a transaction that has not been committed "
- An entry in the console log stating "Error: Range error: Range is no longer valid after DOM mutation ([WrappedRange("Zz":1, "Zz":1)]) "
- The redo button suddenly inserting "♙" once in Chrome.
- The undo button suddenly inserting an endless steam "♙" in Firefox.
Comment 1 John Mark Vandenberg 2013-07-27 06:11:33 UTC
I've reproduced a few of these permutations.
Comment 2 Platonides 2013-08-14 13:40:25 UTC
It's obviusly inviting you to play chess :)
Comment 3 Gerrit Notification Bot 2013-08-14 13:48:49 UTC
Change 79049 had a related patch set uploaded by Esanders:
Check for past/future state in undo/redo before setting breakpoint

https://gerrit.wikimedia.org/r/79049
Comment 4 Gerrit Notification Bot 2013-08-16 02:44:46 UTC
Change 79049 merged by jenkins-bot:
Check for past/future state in undo/redo before setting breakpoint

https://gerrit.wikimedia.org/r/79049
Comment 5 James Forrester 2013-08-16 02:50:06 UTC
Now merged into master; will be deployed in the next push.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links