Last modified: 2013-07-31 16:24:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54114, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 52114 - Use some local settings file for rt-server server.js
Use some local settings file for rt-server server.js
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
tests (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Marc Ordinas i Llopis
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-26 20:47 UTC by ssastry
Modified: 2013-07-31 16:24 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description ssastry 2013-07-26 20:47:27 UTC
Maybe make the time to wait between retries a commandline parameter?  That way, we can play with that value without requiring new code commits.  For example, 5 mins. maybe more than enough time to wait between retries.

Another thing to consider is add an equivalent of server.settings.js file for server config with db info, and settings like this.
Comment 1 Marc Ordinas i Llopis 2013-07-29 15:02:47 UTC
Seems easy enough, at least adding the command line parameters. If both command line and settings file are present, though, which one should take priority?
Comment 2 ssastry 2013-07-29 17:30:18 UTC
commandline takes priority.  settings file provides sensible defaults for the install which you can override temporarily via the commandline.
Comment 3 Gerrit Notification Bot 2013-07-30 18:12:12 UTC
Change 76754 had a related patch set uploaded by Marcoil:
Use a local settings file for rt-test server.js, add more options.

https://gerrit.wikimedia.org/r/76754
Comment 4 Gerrit Notification Bot 2013-07-31 15:43:18 UTC
Change 76754 merged by jenkins-bot:
Use a local settings file for rt-test server.js, add more options.

https://gerrit.wikimedia.org/r/76754
Comment 5 Marc Ordinas i Llopis 2013-07-31 16:24:13 UTC
Fix is in rt_testing branch, reopen if more work is necessary before merging into master.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links