Last modified: 2013-09-20 16:23:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54119, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 52119 - OAuth extension should have PHPUnit tests
OAuth extension should have PHPUnit tests
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
OAuth (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-26 21:36 UTC by Siebrand Mazeland
Modified: 2013-09-20 16:23 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Siebrand Mazeland 2013-07-26 21:36:42 UTC
OAuth extension should have Jenkins jobs, and currently doesn't.

There is a tests/ folder at the moment, but it's unclear to me if those are PHPUnit tests. PHPUnit tests may be advisable.
Comment 1 Gerrit Notification Bot 2013-07-27 09:12:14 UTC
Change 76272 had a related patch set uploaded by Hashar:
jobs for mw/ext/Oauth

https://gerrit.wikimedia.org/r/76272
Comment 2 Gerrit Notification Bot 2013-07-27 09:14:10 UTC
Change 76273 had a related patch set uploaded by Hashar:
triggers for mw/ext/Oauth

https://gerrit.wikimedia.org/r/76273
Comment 3 Gerrit Notification Bot 2013-07-27 09:14:51 UTC
Change 76273 merged by jenkins-bot:
triggers for mw/ext/Oauth

https://gerrit.wikimedia.org/r/76273
Comment 4 Gerrit Notification Bot 2013-07-27 09:15:14 UTC
Change 76272 merged by Hashar:
jobs for mw/ext/Oauth

https://gerrit.wikimedia.org/r/76272
Comment 5 Gerrit Notification Bot 2013-07-27 09:17:01 UTC
Change 76274 had a related patch set uploaded by Hashar:
Oauth -> OAuth

https://gerrit.wikimedia.org/r/76274
Comment 6 Gerrit Notification Bot 2013-07-27 09:18:00 UTC
Change 76275 had a related patch set uploaded by Hashar:
Oauth -> OAuth

https://gerrit.wikimedia.org/r/76275
Comment 7 Gerrit Notification Bot 2013-07-27 09:18:29 UTC
Change 76274 merged by Hashar:
Oauth -> OAuth

https://gerrit.wikimedia.org/r/76274
Comment 8 Gerrit Notification Bot 2013-07-27 09:18:36 UTC
Change 76275 merged by Hashar:
Oauth -> OAuth

https://gerrit.wikimedia.org/r/76275
Comment 9 Gerrit Notification Bot 2013-07-27 09:19:30 UTC
Change 76276 had a related patch set uploaded by Hashar:
Jenkins job validation (DO NOT SUBMIT)

https://gerrit.wikimedia.org/r/76276
Comment 10 Antoine "hashar" Musso (WMF) 2013-07-27 09:23:38 UTC
Build succeeded.
https://integration.wikimedia.org/ci/job/mwext-OAuth-jslint/1/console : SUCCESS in 0s (non-voting)
https://integration.wikimedia.org/ci/job/mwext-OAuth-lint/1/console : SUCCESS in 0s
https://integration.wikimedia.org/ci/job/mwext-OAuth-testextensions-master/1/console : SUCCESS in 1s


Tests are not tests registered via the UnitTestsList hook though.
Comment 11 Antoine "hashar" Musso (WMF) 2013-07-27 09:29:36 UTC
The two tests under /tests/ seems to be manual integration tests, they always exit 0 which is not ideal :]

The tests should be converted to PHPUnit tests and registered via UnitTestsList hook.  From there they will be running in Jenkins which I have setup with the above changes.

Redirecting bug to MediaWiki extensions -> OAuth
Comment 12 Gerrit Notification Bot 2013-07-30 09:22:10 UTC
Change 76276 abandoned by Hashar:
Jenkins job validation (DO NOT SUBMIT)

https://gerrit.wikimedia.org/r/76276
Comment 13 Brad Jorsch 2013-09-20 15:51:09 UTC
Closing this since Gerrit change #79298 added PHPUnit tests a month ago already.
Comment 14 Antoine "hashar" Musso (WMF) 2013-09-20 16:23:25 UTC
They are even triggered by Zuul :-] https://integration.wikimedia.org/ci/job/mwext-OAuth-testextensions-master/

\O/

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links