Last modified: 2013-08-02 17:13:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54146, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 52146 - selser changes should be kept up to date with parserTests.txt
selser changes should be kept up to date with parserTests.txt
Status: RESOLVED INVALID
Product: Parsoid
Classification: Unclassified
tests (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: C. Scott Ananian
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-07-27 14:09 UTC by C. Scott Ananian
Modified: 2013-08-02 17:13 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description C. Scott Ananian 2013-07-27 14:09:08 UTC 
We should probably add a check to jenkins which regenerates the selser.changes file (since this should be deterministic) for every patch, and verifies that there are no diffs.  We seem to be forgetting to update selser.changes when parserTests.txt is updated.
Comment 1 ssastry 2013-07-27 15:49:42 UTC 
I think dealing with bug 50316 might be a better fix than this.
Comment 2 ssastry 2013-08-02 17:13:48 UTC 
Now that selser changes are generated dynamically without relying on an external file, this is no longer a concern.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links