Last modified: 2013-11-19 10:38:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54175, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 52175 - VisualEditor: Save dialog's checkboxes layout terribly if you have more than 2 items, or long i18n strings
VisualEditor: Save dialog's checkboxes layout terribly if you have more than ...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: High minor
: VE-deploy-2013-10-10
Assigned To: Rob Moen
:
: 52176 54802 (view as bug list)
Depends on:
Blocks: ve-nonenglish
  Show dependency tree / graph
 
Reported: 2013-07-28 07:29 UTC by John Mark Vandenberg
Modified: 2013-11-19 10:38 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
screenshot (282.19 KB, image/png)
2013-07-28 07:29 UTC, John Mark Vandenberg 		Details
Windows 7 screenshot (7.66 KB, image/png)
2013-07-29 01:33 UTC, John Mark Vandenberg 		Details
pl.wp screenshot (21.79 KB, image/png)
2013-09-04 20:10 UTC, Bartosz Dziewoński 		Details
Screenshot, 2013-11-17 (in Polish) (22.42 KB, image/png)
2013-11-17 14:22 UTC, Bartosz Dziewoński 		Details
Show Obsolete (3) Add an attachment (proposed patch, testcase, etc.)

Description John Mark Vandenberg 2013-07-28 07:29:02 UTC 
Created attachment 12990 [details]
screenshot

When using German language (on German and English Wikipedia, but also likely everywhere else), the layout of the minor changes & watchlist checkboxes on the save dialog is not appropriate when viewed in Firefox.  Attached is Vector; same problem exists in Monobook.
Comment 1 John Mark Vandenberg 2013-07-29 01:33:15 UTC 
Created attachment 12997 [details]
Windows 7 screenshot

Font is obviously a contributing factor here; on Windows the layout problem almost disappears.
Comment 2 James Forrester 2013-08-29 22:27:41 UTC 
*** Bug 52176 has been marked as a duplicate of this bug. ***
Comment 3 Bartosz Dziewoński 2013-09-04 20:10:42 UTC 
Created attachment 13242 [details]
pl.wp screenshot

It breaks particularly badly on wikis with FlaggedRevs.
Comment 4 Gerrit Notification Bot 2013-09-04 20:14:09 UTC 
Change 81876 had a related patch set uploaded by Jforrester:
Make the save dialog an actual dialog

https://gerrit.wikimedia.org/r/81876
Comment 5 James Forrester 2013-10-03 20:53:45 UTC 
*** Bug 54802 has been marked as a duplicate of this bug. ***
Comment 6 Gerrit Notification Bot 2013-10-07 23:02:00 UTC 
Change 81876 merged by jenkins-bot:
Make the save dialog an actual dialog

https://gerrit.wikimedia.org/r/81876
Comment 7 James Forrester 2013-10-07 23:04:22 UTC 
The fix for this is now merged and will be deployed on Thursday 10 October to MediaWiki.org, and to Wikipedias on Thursday 17 October.
Comment 8 Bartosz Dziewoński 2013-11-17 14:22:25 UTC 
Created attachment 13820 [details]
Screenshot, 2013-11-17 (in Polish)

This appears to still not fixed :( I'm adding an up-to-date screenshot.
Comment 9 James Forrester 2013-11-19 06:28:27 UTC 
Reset as FIXED. The screenshot you attach looks normal - could you annotate the parts you think aren't correct? Probably as a new bug…
Comment 10 Bartosz Dziewoński 2013-11-19 10:38:50 UTC 
The line-height is too large and the second line is offset to left.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links