Last modified: 2014-07-11 00:23:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54182, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 52182 - VisualEditor: On "applying changes" in a reference dialog, if the contents are blank, just delete the reference
VisualEditor: On "applying changes" in a reference dialog, if the contents ar...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Normal minor
: VE-deploy-2014-06-05
Assigned To: Alex Monk
:
: 62399 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-28 10:45 UTC by John Mark Vandenberg
Modified: 2014-07-11 00:23 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description John Mark Vandenberg 2013-07-28 10:45:32 UTC
Removing the content from out of a <ref> .. </ref> should prompt the user that they need to delete the reference.  Perhaps a tooltip, or this might be an opportunity to use a hover trick to give the user something to click to acknowledge they intended to delete the ref.

It shouldnt be possible to save with an empty ref, as that is an error condition.

https://en.wikipedia.org/w/index.php?title=User:John_Vandenberg/test&diff=566133128&oldid=566132993
Comment 1 Alex Monk 2014-05-30 18:48:19 UTC
According to ve.ui.MWReferenceDialog.prototype.onDocumentTransact, this apply button is supposed to be disabled when the length is less than 4. But when I empty the box, the length is 10 so nothing is done.

Anyway, I think we should either:
* Fix that bug (if it is one) and mark this bug as invalid (or repurposed for fixing it), or
* Replace that with this idea
Comment 2 James Forrester 2014-05-30 18:54:51 UTC
length < 4 is a hack and we probably shouldn't be using it…
Comment 3 Alex Monk 2014-05-30 18:56:18 UTC
See Gerrit change #81438 and Gerrit change #88618
Comment 4 Alex Monk 2014-05-30 19:52:16 UTC
*** Bug 62399 has been marked as a duplicate of this bug. ***
Comment 5 Alex Monk 2014-06-03 15:20:48 UTC
So Gerrit change #136496 fixed the existing intended behaviour, but didn't go as far as this bug suggests (it just disables the apply button rather than deleting the reference) - should it be changed to delete the reference still?
Comment 6 Alex Monk 2014-07-11 00:21:16 UTC
Ping. Anyone want to answer my question?
Comment 7 James Forrester 2014-07-11 00:23:35 UTC
Yes, sorry, this was great. Thanks!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links