Last modified: 2013-08-09 03:01:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54190, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 52190 - <gallery> with |link=<external link> doesn't work on wikis with LanguageConverter
<gallery> with |link=<external link> doesn't work on wikis with LanguageConve...
Status: PATCH_TO_REVIEW
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
1.22.0
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-28 12:38 UTC by Liangent
Modified: 2013-08-09 03:01 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Comment 1 Gerrit Notification Bot 2013-07-28 12:50:28 UTC
Change 76341 had a related patch set uploaded by Liangent:
LanguageConverter fixes to eliminate parser test failures

https://gerrit.wikimedia.org/r/76341
Comment 2 C. Scott Ananian 2013-08-08 21:48:40 UTC
The root cause is that:

<gallery>
File:foobar.jpg|caption|link=http://google.com
</gallery>

is expanded to:
<gallery>
File:foobar.jpg|caption|link=<a rel="nofollow" class="external free" href="http://google.com">-{R|http://google.com}-</a>
</gallery>

and then the embedded | in the link text screws up the caption parsing.

What does -{R|...}- do?  It doesn't seem to be documented at https://www.mediawiki.org/wiki/Writing_systems/Syntax
Comment 3 Liangent 2013-08-09 03:01:38 UTC
(In reply to comment #2)
> The root cause is that:
> 
> <gallery>
> File:foobar.jpg|caption|link=http://google.com
> </gallery>
> 
> is expanded to:
> <gallery>
> File:foobar.jpg|caption|link=<a rel="nofollow" class="external free"
> href="http://google.com">-{R|http://google.com}-</a>
> </gallery>
> 
> and then the embedded | in the link text screws up the caption parsing.
> 
> What does -{R|...}- do?  It doesn't seem to be documented at
> https://www.mediawiki.org/wiki/Writing_systems/Syntax

https://www.mediawiki.org/w/index.php?title=Writing_systems/Syntax&diff=759781&oldid=667003

It's usually used in auto-generated -{ }- tags, in case some text already contains a pipe in it triggering other syntax.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links