Last modified: 2013-07-29 17:40:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54220, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 52220 - LogPage.php assumes that $wgLogActionsHandlers contains callbacks, but usually contains class names
LogPage.php assumes that $wgLogActionsHandlers contains callbacks, but usuall...
Status: NEW
Product: MediaWiki
Classification: Unclassified
Logging (Other open bugs)
1.22.0
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-07-29 14:21 UTC by Bawolff (Brian Wolff)
Modified: 2013-07-29 17:40 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Bawolff (Brian Wolff) 2013-07-29 14:21:43 UTC 
$wgLogActionsHandlers normally contains class names, but on line 296, its treated as if it contained callbacks. This is normally not reached, unless $wgLogActions is not set.

I'm not sure if this is intentional as some sort of back compat thing. If it is, this should sanity check that the given value is_callable to prevent fatals. It would be nice if how that value is used was better documented.
Comment 1 Niklas Laxström 2013-07-29 17:21:29 UTC 
It used to have functions, but in the write I turned it into classes. If there is code which cannot handle both classes and callables, that is a bug.
Comment 2 Bawolff (Brian Wolff) 2013-07-29 17:40:54 UTC 
(In reply to comment #1)
> It used to have functions, but in the write I turned it into classes. If
> there
> is code which cannot handle both classes and callables, that is a bug.

There was someone on irc who was getting fatals because code was expecting callables. Its likely that this person's set up was very borked, but nonetheless.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links