Last modified: 2013-08-30 01:09:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54228, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 52228 - VisualEditor: VE will not save multiple consecutive references
VisualEditor: VE will not save multiple consecutive references
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Data Model (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2013-08-15
Assigned To: Roan Kattouw
:
: 52269 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-29 17:03 UTC by Maggie Dennis
Modified: 2013-08-30 01:09 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Maggie Dennis 2013-07-29 17:03:51 UTC
Following a report of the issue by a user, I attempted to add multiple consecutive references. I began with bare URLs and started with 6. You can see that VE thinks it is going okay (http://en.wikipedia.org/wiki/File:VEmultiref.png), but when you save it only saves one (http://en.wikipedia.org/w/index.php?title=User%3AMdennis_%28WMF%29%2Fsandbox&diff=566304458&oldid=566304152)

I tested it all the way down to two.

In case it was an issue with bare refs, I tried it using citation templates, and it would also not save two in a row. It still only saved one:
http://en.wikipedia.org/w/index.php?title=User%3AMdennis_%28WMF%29%2Fsandbox&diff=566306613&oldid=566306049

I'm using Chrome, Windows 7.
Comment 1 Roan Kattouw 2013-07-30 21:14:05 UTC
This happens because we send Parsoid something like

<span about="undefined" typeof="mw:Extension/ref" data-mw="..."></span><span about="undefined" typeof="mw:Extension/ref" data-mw="..."></span>

which then gets about-grouped. We need to just drop the about attribute if we don't have it.

Ironically we've had breakage in the other direction before, where Parsoid output multiple adjacent images with about="null". Karma's a bitch :)
Comment 2 Gerrit Notification Bot 2013-07-30 21:51:06 UTC
Change 76836 had a related patch set uploaded by Catrope:
Remove the DM 'about' attribute from references and reference lists

https://gerrit.wikimedia.org/r/76836
Comment 3 Gerrit Notification Bot 2013-07-30 22:12:20 UTC
Change 76836 merged by jenkins-bot:
Remove the DM 'about' attribute from references and reference lists

https://gerrit.wikimedia.org/r/76836
Comment 4 James Forrester 2013-07-30 22:13:33 UTC
Fixed and will get deployed in a little while.
Comment 5 Chris McKenna 2013-08-12 16:36:06 UTC
*** Bug 52269 has been marked as a duplicate of this bug. ***
Comment 6 Chris McKenna 2013-08-27 09:54:18 UTC
Users are reporting that VE is still not saving multiple references:

Reported today by The Devil's Advocate
if I add multiple citations to back a statement, the Visual Editor only saves the first citation I added. This happened once when I added three citations to back a claim and had to add each one individually over the course of three edits and again just now when I had to add a second citation after it didn't get saved. Multiple citations can be added if they are separate as I had added a citation for another statement in the same edit and it was saved.

Reported on the 22nd by Sue Gardner
Last night I created a new article with multiple references, and when I saved the page many of the references disappeared and some I think had jumped around. (I didn't save-as-I-went -- I wrote the whole thing and saved once, at the end.) I can't describe exactly what happened, but here's a diff: [1] the latest revision [2] is roughly what I was aiming to do, and the earlier revision [3] is what I actually achieved. (Ignore the missing reflist: I just hadn't gotten around to figuring out how to add it in VE yet, so I did it afterwards in wiki syntax.)

So, in my initial VE save, it looks like references #5, 6 & 7 disappeared as did #14 and 15. (Numbers taken from the latest revision.) This suggests to me there's a problem with VE saving multiple adjacent references -- when there are multiples adjacent, it seems to save only the first. I think also some references jumped around, but I'm not 100% sure about that.

[1] https://en.wikipedia.org/w/index.php?title=Mansplaining&diff=569638597&oldid=569526861
[2] https://en.wikipedia.org/w/index.php?title=Mansplaining&oldid=569638597
[3] https://en.wikipedia.org/w/index.php?title=Mansplaining&oldid=569526861
Comment 7 James Forrester 2013-08-30 01:09:04 UTC
(In reply to comment #6)
> Users are reporting that VE is still not saving multiple references:

Unfortunately, this is "again", not "still", and is caused by bug 53434 in Parsoid, I think. :-( Marking this as "fixed" but highlighting on that one how urgent this is. Sorry for the disruption.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links