Last modified: 2013-07-30 03:48:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54232, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 52232 - Anonymous users getting VisualEditor on German Wikipedia and making edits
Anonymous users getting VisualEditor on German Wikipedia and making edits
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Site requests (Other open bugs)
unspecified
All All
: Highest normal (vote)
: ---
Assigned To: Krinkle
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-29 17:48 UTC by MZMcBride
Modified: 2013-07-30 03:48 UTC (History)
11 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description MZMcBride 2013-07-29 17:48:23 UTC
https://de.wikipedia.org/w/index.php?title=Spezial:Letzte_%C3%84nderungen&limit=500&days=30&hideliu=1&tagfilter=visualeditor

---
29 July 2013

(diff | hist) . . Aurich‎ [pending edits]; 19:40 . . (-1)‎ . . ‎95.165.106.6 (Talk)‎ (→‎Branchen und Unternehmen) (Tag: VisualEditor)
(diff | hist) . . Djihadismus‎; 19:30 . . (-980)‎ . . ‎2a02:908:df31:8700:6861:a2d8:52b6:1392 (Talk)‎ (Tag: VisualEditor)
(diff | hist) . . Thronfolge (Vereinigtes Königreich)‎ [pending edits]; 19:30 . . (-2)‎ . . ‎84.155.202.154 (Talk)‎ (→‎Derzeitige Reihenfolge der Thronfolge) (Tag: VisualEditor)
(diff | hist) . . Lagerungskonzepte‎ [pending edits]; 19:15 . . (+73)‎ . . ‎81.217.18.166 (Talk)‎ (→‎Stützlagerung schwimmend (SLS)) (Tag: VisualEditor)
(diff | hist) . . Andreas Müller (Fußballspieler, 1962)‎; 19:13 . . (+233)‎ . . ‎2.244.238.208 (Talk)‎ (→‎als Funktionär) (Tag: VisualEditor)
(diff | hist) . . Nexus 7‎; 19:12 . . (+4)‎ . . ‎88.130.17.139 (Talk)‎ (→‎Zweite Generation (2013)) (Tag: VisualEditor)
(diff | hist) . . Räumliche Orientierung‎ [pending edits]; 19:09 . . (-55)‎ . . ‎72.89.247.161 (Talk)‎ (für emotionale Betroffenheit lassen sich in der Literatur keine Belege finden.) (Tag: VisualEditor)
(diff | hist) . . Medien (Land)‎; 19:06 . . (+226)‎ . . ‎78.53.45.165 (Talk)‎ (→‎Spekulationen über die Verwandtschaft von Kurden und Medern) (Tag: VisualEditor)
(diff | hist) . . Inka Bause‎; 19:05 . . (+42)‎ . . ‎188.194.150.121 (Talk)‎ (→‎Singles:   ist das liebe 1987) (Tag: VisualEditor)
(diff | hist) . . Mississippi River‎; 19:03 . . (+1)‎ . . ‎77.6.118.157 (Talk)‎ (Tag: VisualEditor)
(diff | hist) . . Geständnisse‎ [pending edits]; 18:54 . . (+1)‎ . . ‎91.39.63.227 (Talk)‎ (→‎Handlung:  Grammatik) (Tag: VisualEditor)
(diff | hist) . . Vojtech Tuka‎; 18:53 . . (-23)‎ . . ‎2003:4d:eb3c:f001:5452:a193:58c6:cc59 (Talk)‎ (→‎Flucht, Prozess und Hinrichtung) (Tag: VisualEditor)

25 July 2013

(diff | hist) . . Lotta Schelin‎; 04:26 . . (+2)‎ . . ‎92.76.236.197 (Talk)‎ (→‎Nationalmannschaft) (Tag: VisualEditor)
---

Anons are editing the German Wikipedia with VisualEditor.

My suspicion is that logged-in users are hitting certain pages, the pages are being cached, and then anons are receiving these cached pages (with the VE init JS loaded).
Comment 1 James Forrester 2013-07-29 18:26:20 UTC
This appears to be a caching issue, yes
Comment 2 Gerrit Notification Bot 2013-07-29 18:49:12 UTC
Change 76552 had a related patch set uploaded by Catrope:
Explicitly disable VE for anons on dewiki

https://gerrit.wikimedia.org/r/76552
Comment 3 Gerrit Notification Bot 2013-07-29 18:50:42 UTC
Change 76552 merged by jenkins-bot:
Explicitly disable VE for anons on dewiki

https://gerrit.wikimedia.org/r/76552
Comment 4 Krinkle 2013-07-29 18:58:07 UTC
(In reply to comment #0)
> My suspicion is that logged-in users are hitting certain pages, the pages are
> being cached, and then anons are receiving these cached pages (with the VE
> init
> JS loaded).

We don't mix user preference cache between logged-in users and logged-out users, this is definitely not what's happening.


What's happening is that a while ago the 'visualeditor-enable' preference was enabled by default on de.wikipedia.org. Though it was disabled for anonymous users by other means, that preference was there and as such is cached inside the anonymous user cache that visited pages while VE was enabled by default on de.wikipedia.org.

The 'other' means to disable for anons have been removed now that the preference is disabled again on de.wikipedia (it is now an opt-in for logged-in users). However this other means is not cached inside the page but globally from the startup module.

So people visiting the pages generated while VE was enabled by default are now getting VE since there is no 'disableForAnons' flag in place.

Roan's putting this in place now.
Comment 5 Roan Kattouw 2013-07-29 19:05:10 UTC
(In reply to comment #4)
> Roan's putting this in place now.
Done. This bug should stop happening in the next ~10 minutes.
Comment 6 MZMcBride 2013-07-29 22:08:41 UTC
For the record, if my patch set from Gerrit change #76199 and Gerrit change #76468 had been merged and deployed, this bug never would have happened.

I'm fairly annoyed that I was told that VisualEditor "doesn't work the way you think it does" this morning and my patch sets were roundly and soundly ignored (in favor of Gerrit change #76516), only to have the exact changes implemented a few hours later after this bug appeared.
Comment 7 Roan Kattouw 2013-07-30 00:27:41 UTC
(In reply to comment #6)
> I'm fairly annoyed that I was told that VisualEditor "doesn't work the way
> you
> think it does" this morning and my patch sets were roundly and soundly
> ignored
> (in favor of Gerrit change #76516), only to have the exact changes
> implemented a few hours later after this bug appeared.
Your patchsets weren't ignored, we worked off them. At the time we honestly believed that this was unnecessary, and the code that uses them is written in a way that leads the reader to believe that it is unnecessary: if wmgVisualEditorDefault is false, wmgVisualEditorDisableForAnons is unused.

However, caching threw a wrench in all of this. Two wrongs made a right, if you will.

I'm sorry if we were dismissive earlier. When I said "VE doesn't work the way you think it does", what I meant to say was "despite the confusing way these variables are named, they mean something slightly different, such that one of them is unused if the other one is set a certain way".
Comment 8 MZMcBride 2013-07-30 03:48:29 UTC
(In reply to comment #7)
> I'm sorry if we were dismissive earlier. When I said "VE doesn't work the way
> you think it does", what I meant to say was "despite the confusing way these
> variables are named, they mean something slightly different, such that one of
> them is unused if the other one is set a certain way".

I wasn't annoyed with you (and you weren't the person quoted in comment 6). You're wonderful and I adore you.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links