Last modified: 2014-04-23 20:00:39 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54280, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 52280 - VisualEditor: The on-page Flagged Revisions notice about transcluded files or templates having outstanding changes doesn't appear in the edit notices
VisualEditor: The on-page Flagged Revisions notice about transcluded files or...
Status: PATCH_TO_REVIEW
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Normal enhancement
: ---
Assigned To: Alex Monk
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-07-30 17:15 UTC by Keegan Peterzell
Modified: 2014-04-23 20:00 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Keegan Peterzell 2013-07-30 17:15:10 UTC 
When a page has pending edits and it is opened for editing using VisualEditor, there is a dropdown box with a notice about this.  When a page has a template or a file with pending changes is opened for editing, the dropdown box does not appear.

An example on the Russian Wikipedia:
https://ru.wikipedia.org/wiki/%D0%98%D1%80%D0%B3%D0%B8%D1%88
Comment 1 Keegan Peterzell 2013-07-30 18:04:02 UTC 
Specifically, not only does the dropdown box not appear, but the notice that was on the page before clicking "edit" disappears, leaving absolutely no notice.
Comment 2 James Forrester 2013-07-30 20:32:35 UTC 
Yes, this is intentional (as the tool interferes with VisualEditor and will need re-writing/merging into VE to work properly).

The notice above the page having transcluded files or templates with outstanding changes feels like one of the things that should appear in the wikitext page's edit notices (and so on VisualEditor's panel too) - not sure why it doesn't. Is this a Pending Changes bug?
Comment 3 Alex Monk 2014-04-04 14:45:45 UTC 
Shouldn't this appear on the wikitext editor too then?
Comment 4 Gerrit Notification Bot 2014-04-04 15:34:25 UTC 
Change 123875 had a related patch set uploaded by Alex Monk:
Show pending changes notice about unstable transclusions in VE

https://gerrit.wikimedia.org/r/123875
Comment 5 James Forrester 2014-04-04 17:25:49 UTC 
(In reply to Alex Monk from comment #3)
> Shouldn't this appear on the wikitext editor too then?

Maybe create a further bug for that in FlaggedRevisions?
Comment 6 Alex Monk 2014-04-04 20:48:09 UTC 
(In reply to James Forrester from comment #5)
> (In reply to Alex Monk from comment #3)
> > Shouldn't this appear on the wikitext editor too then?
> 
> Maybe create a further bug for that in FlaggedRevisions?

I just noticed that it was already made - by you. And it's what this bug is marked as depending on.
Comment 7 James Forrester 2014-04-04 20:49:36 UTC 
(In reply to Alex Monk from comment #6)
> (In reply to James Forrester from comment #5)
> > (In reply to Alex Monk from comment #3)
> > > Shouldn't this appear on the wikitext editor too then?
> > 
> > Maybe create a further bug for that in FlaggedRevisions?
> 
> I just noticed that it was already made - by you. And it's what this bug is
> marked as depending on.

Ha. Never mind me. :-)
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links