Last modified: 2013-09-26 15:20:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54286, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 52286 - Corrected words aren't bolded in suggestions


Summary:	Corrected words aren't bolded in suggestions

Status:	VERIFIED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	CirrusSearch (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:	Elasticsearch0.90.4
Keywords:	upstream

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-07-30 18:54 UTC by Nik Everett
Modified:	2013-09-26 15:20 UTC (History)
CC List:	2 users (show)

See Also:	https://github.com/elasticsearch/elasticsearch/issues/3442
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Nik Everett 2013-07-30 18:54:45 UTC

Searching for "popular Culatur" yields a suggestion (did you mean:) but doesn't correctly bold the corrected word.

URL:  http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special%3ASearch&profile=default&search=popular+Culatur&fulltext=Search

Comment 1 Nik Everett 2013-07-31 16:53:15 UTC

I have a question out to the elasticsearch mailing lists for this topic.

Comment 2 Nik Everett 2013-08-05 16:04:26 UTC

I have a feature request in with Elasticsearch to make this more efficient but that is in its early stages.  If we can live without this for a month we should just wait until that has made it through their process.  Otherwise we can accomplish this with either one off space-splitting based code or by making calls to the analyze endpoint in elasticsearch for the original terms and the suggestion, then correlate them.

Comment 3 Nik Everett 2013-08-07 17:17:38 UTC

This is currently waiting on Elasticsearch 0.90.4.  Like I mentioned before we can work around not having the feature but it should be available for easy consumption in a month or so.

Comment 4 Gerrit Notification Bot 2013-09-20 13:55:23 UTC

Change 85206 had a related patch set uploaded by Manybubbles:
Highlight changed words in suggestions.

https://gerrit.wikimedia.org/r/85206

Comment 5 Gerrit Notification Bot 2013-09-20 13:56:31 UTC

Change 85207 had a related patch set uploaded by Manybubbles:
Tests for highlight changed words in suggestions.

https://gerrit.wikimedia.org/r/85207

Comment 6 Gerrit Notification Bot 2013-09-20 18:03:06 UTC

Change 85206 merged by jenkins-bot:
Highlight changed words in suggestions.

https://gerrit.wikimedia.org/r/85206

Comment 7 Gerrit Notification Bot 2013-09-20 18:09:29 UTC

Change 85207 merged by jenkins-bot:
Tests for highlight changed words in suggestions.

https://gerrit.wikimedia.org/r/85207

Comment 8 Nik Everett 2013-09-26 15:20:41 UTC

Verified on mediawiki.org.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links