Last modified: 2013-08-15 01:00:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54296, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 52296 - Certification templates not parsed correctly
Certification templates not parsed correctly
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-30 21:09 UTC by kwwilliams
Modified: 2013-08-15 01:00 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description kwwilliams 2013-07-30 21:09:38 UTC
Per http://parsoid.wmflabs.org/en/User:Kww/certtable the failure to display the certification template tables in http://en.wikipedia.org/wiki/User:Kww/certtable (live version http://en.wikipedia.org/w/index.php?title=Metallica_%28album%29&oldid=566196578&veaction=edit) appears to be rooted in Parsoid. This means that it must be a different bug than 50589 but may be related to 44498.
Comment 1 ssastry 2013-07-30 21:15:47 UTC
It is unrelated to 44498.  I've been investigating this and the parser introduces an empty <td></td> when parsing {{Certification Table Top}}.  This doesn't happen when I copy the wikitext verbatim and parse it on its own.  So, just an edge case which should be fixable relatively easily.
Comment 2 kwwilliams 2013-07-30 21:41:48 UTC
Based on ssastry's commment, I went ahead and did a "subst" on "Certification Table Top" and "Certification Table Bottom". It got worse: http://en.wikipedia.org/wiki/User:Kww/certtablesubst?veaction=edit and http://parsoid.wmflabs.org/en/User:Kww/certtablesubst
Comment 3 Gerrit Notification Bot 2013-07-30 22:42:49 UTC
Change 76842 had a related patch set uploaded by Subramanya Sastry:
WIP: (Bug 52296) Delete empty autoinserted tags in the last DOM pass

https://gerrit.wikimedia.org/r/76842
Comment 4 ssastry 2013-07-30 22:48:54 UTC
The subst-related parse issues are unrelated to the bug that we are fixing here.  But, the patch above deals with the empty-cell scenarios that break the table on the Metallica album page.
Comment 5 Gerrit Notification Bot 2013-08-02 23:13:46 UTC
Change 76842 merged by jenkins-bot:
(Bug 52296) Delete empty autoinserted tags in the last DOM pass

https://gerrit.wikimedia.org/r/76842
Comment 6 ssastry 2013-08-14 22:47:28 UTC
This fix has now been deployed and verified that User:Kww/certtable now shows up correctly in VE.

I am going to reopen Metallica album page for editing.

Closing -- please reopen if you see a problem.
Comment 7 kwwilliams 2013-08-15 00:25:04 UTC
Please don't reenable editing on that page until 52254 is also fixed.
Comment 8 ssastry 2013-08-15 01:00:40 UTC
Yes, I noticed the other related bug and didn't re-enable it.  I meant to update the bug report, but I got sucked into verifying other bug fixes.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links