Last modified: 2013-07-31 23:23:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54317, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 52317 - VisualEditor: [Regression] Save dialog sometimes attaches to context menu toolbar instead of platform toolbar
VisualEditor: [Regression] Save dialog sometimes attaches to context menu too...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Highest critical
: VE-deploy-2013-08-15
Assigned To: Krinkle
:
: 52328 52346 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-31 09:07 UTC by Raimond Spekking
Modified: 2013-07-31 23:23 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot (68.59 KB, image/png)
2013-07-31 09:07 UTC, Raimond Spekking
Details

Description Raimond Spekking 2013-07-31 09:07:10 UTC
Created attachment 13027 [details]
Screenshot

Since the VE update tonight the save dialog is half out of the screen on FF 23/Win7, but sometimes only.
Comment 1 Chris McKenna 2013-07-31 14:26:15 UTC
There is a lot of discussion about this at https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback#Save_page_box_drops.2C_button_invisible_without_scrolling_..._but_fixes_itself_given_time including two screenshots: [[File:VE save form off screen.png]] and [[File:VE misplaced save box.jpg]]

From my testing it seems that if an element is selected (picture, link, template) when you click save then the dialog aligns itself to the top right of that element, regardless of whether there is space on screen for it, with scroll bars if there isn't sufficient vertical space in the window to show the whole dialog. If you close the dialog, deselect the element then open the save box again it appears in the same place, only based on what that element is in the view now. If you close and select a different element then save, it relates to that element. If you have not selected any elements during your edit it appears overthe save button.

Steps to reproduce:
1. Edit a page in VE
2. Make a change to the page (doesn't matter what)
3. Click on an element (link, image, template) near the lower left edge of the window.
4. Click the save button in the top right.
Comment 2 James Forrester 2013-07-31 16:08:29 UTC
Renamed.

Removing the link to bug 49969 - the save dialog isn't (yet) an actual dialog, so that would have no effect.

Adding a link to bug 52326 which is possibly caused by the same
Comment 3 Gerrit Notification Bot 2013-07-31 16:15:57 UTC
Change 76935 had a related patch set uploaded by Krinkle:
ve.ui.Toolbar: Emit position event on toolbar instead of surface

https://gerrit.wikimedia.org/r/76935
Comment 4 Krinkle 2013-07-31 16:18:02 UTC
Basically it attaches to whichever toolbar is positioned last. So if you click on a link, and then open the save dialog, it pops up there. If you then scroll down (which updates position of platform toolbar), it moves to that one.
Comment 5 WhatamIdoing 2013-07-31 17:28:00 UTC
I have a report of this sort of problem with a misplaced save dialog box appearing in the lower left corner.  The editor is running Linux Mint 14 and Firefox 18.0.2.  See  http://i40.tinypic.com/2eojvh1.jpg and http://i41.tinypic.com/30wqpnb.jpg for his screenshots.

The original problem description can be found at Wikipedia:VisualEditor/Opinie#b.C5.82.C4.99dnie_wy.C5.9Bwietlaj.C4.85ce_si.C4.99_okno_opisu_zmian
Comment 6 Chris McKenna 2013-07-31 18:49:54 UTC
Whatamidoing's link is to the Polish Wikipedia:
[[pl:Wikipedia:VisualEditor/Opinie#b.C5.82.C4.99dnie_wy.C5.9Bwietlaj.C4.85ce_si.C4.99_okno_opisu_zmian]]
Comment 7 Bartosz Dziewoński 2013-07-31 20:45:52 UTC
*** Bug 52346 has been marked as a duplicate of this bug. ***
Comment 8 Gerrit Notification Bot 2013-07-31 22:04:06 UTC
Change 76935 merged by jenkins-bot:
ve.ui.Toolbar: Emit position event on toolbar instead of surface

https://gerrit.wikimedia.org/r/76935
Comment 9 James Forrester 2013-07-31 23:22:19 UTC
This is fixed and being pushed live right now.
Comment 10 James Forrester 2013-07-31 23:23:12 UTC
*** Bug 52328 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links