Last modified: 2013-08-22 07:53:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54322, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 52322 - [MLEB] isBrowserSupported is not compatible with MW < 1.21
[MLEB] isBrowserSupported is not compatible with MW < 1.21
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UniversalLanguageSelector (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Amir E. Aharoni
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-31 13:48 UTC by Amir E. Aharoni
Modified: 2013-08-22 07:53 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Amir E. Aharoni 2013-07-31 13:48:47 UTC
ULS in the master version doesn't work with MW < 1.21, because $.client.test returns a different value in MW < 1.21.
Comment 1 Siebrand Mazeland 2013-08-06 06:17:38 UTC
Can we have a root cause analysis for this?

This uses $.client.test( blacklist, null, true ), and has that changed in 1.21? Should that be backported to 1.20, or even 1.19?
Comment 2 Siebrand Mazeland 2013-08-06 06:30:01 UTC
I think this is the cause:

Along the way, a 3rd parameter was added to "test":

@param {boolean} [exactMatchOnly=false] Only return true if the browser is matched, otherwise

As default is false, and this parameter was not present, we can have different behaviour. The question is what exactly goes wrong on MediaWiki <1.21 for which browser(s)? Our blacklist is IE7 and below ('msie': [['<=', 7]]).
Comment 3 Gerrit Notification Bot 2013-08-22 06:33:33 UTC
Change 80339 had a related patch set uploaded by Amire80:
Use the old way of checking browser support for MW < 1.22

https://gerrit.wikimedia.org/r/80339
Comment 4 Gerrit Notification Bot 2013-08-22 07:46:53 UTC
Change 80339 merged by jenkins-bot:
Use the old way of checking browser support for MW < 1.22

https://gerrit.wikimedia.org/r/80339

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links