Last modified: 2014-04-23 20:03:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54345, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 52345 - VisualEditor: API does not apply PST (pre-save transform) when generating its diff
VisualEditor: API does not apply PST (pre-save transform) when generating its...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Normal minor
: VE-deploy-2014-04-24
Assigned To: Alex Monk
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-07-31 20:16 UTC by Bartosz Dziewoński
Modified: 2014-04-23 20:03 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Bartosz Dziewoński 2013-07-31 20:16:56 UTC 
It is possible to insert a substituted template (by just putting in "subst:whatever" as its name). This will be saved correctly (substituted), but the diff shown in the review dialog shows the non-substituted wikitext.
Comment 1 Kunal Mehta (Legoktm) 2013-07-31 20:20:25 UTC 
Isn't this how normal diffs work? If I replace the sandbox with {{subst:test}}, it just shows the addition of the text "{{subst:test}}" when you hit show changes.
Comment 2 Bartosz Dziewoński 2013-07-31 20:25:17 UTC 
No, it shows the substituted code.
Comment 3 Kunal Mehta (Legoktm) 2013-07-31 20:40:17 UTC 
Sorry, my bad. I forgot I was using custom JS to generate diffs.
Comment 4 James Forrester 2013-07-31 20:50:37 UTC 
Marking as "minor" as we don't provide a built-in way for subst: to be added (yet) to transclusion invocations.
Comment 5 James Forrester 2013-08-30 22:57:34 UTC 
VE's API "diff" option instantiates its own DifferenceEngine but fails to set the PST option.
Comment 6 Gerrit Notification Bot 2014-04-23 19:51:07 UTC 
Change 129251 had a related patch set uploaded by Alex Monk:
Apply PST when generating diff

https://gerrit.wikimedia.org/r/129251
Comment 7 Gerrit Notification Bot 2014-04-23 20:03:10 UTC 
Change 129251 merged by jenkins-bot:
Apply PST when generating diff

https://gerrit.wikimedia.org/r/129251
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links