Last modified: 2013-08-27 16:04:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54356, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 52356 - Login check without javascript broken
Login check without javascript broken
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CentralAuth (Other open bugs)
unspecified
All All
: Unprioritized major (vote)
: ---
Assigned To: Chris Steipp
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-31 21:37 UTC by Chris Steipp
Modified: 2013-08-27 16:04 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Chris Steipp 2013-07-31 21:37:30 UTC
Without javascript, the central login check is failing to run correctly.

Local wiki writes an image call that looks something like title=Special:CentralAutoLogin/start&type=1x1&from=enwiki

However, CentralAutoLogin checks for

} elseif( $request->getVal( 'from' ) === wfWikiId() && $wgCentralAuthLoginWiki !== wfWikiId() ) {

Which is true in this case, and so the browser is redirected to the central wiki, to Special:CentralAutoLogin/start, which fails.

The pure javascript version of the check makes a call to:

index.php?title=Special:CentralAutoLogin/start&type=script

So the code above doesn't evaluate true, and everything works.
Comment 1 Brad Jorsch 2013-08-01 13:19:27 UTC
Ah, I see what's happening there. It should fix it to simply remove the "from" parameter from that particular URL; I'll test that and put the patch in Gerrit if it works.
Comment 2 Gerrit Notification Bot 2013-08-01 13:27:08 UTC
Change 77117 had a related patch set uploaded by Anomie:
Fix non-JS login check

https://gerrit.wikimedia.org/r/77117
Comment 3 Gerrit Notification Bot 2013-08-01 18:37:39 UTC
Change 77117 merged by jenkins-bot:
Fix non-JS login check

https://gerrit.wikimedia.org/r/77117
Comment 4 Andre Klapper 2013-08-27 16:04:55 UTC
(In reply to comment #3)
> https://gerrit.wikimedia.org/r/77117

Patch merged on 2013-08-01. Closing as FIXED, but please reopen if more work is needed (and elaborate).

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links