Last modified: 2014-10-28 18:13:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54358, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 52358 - Logging: logs should include PID
Logging: logs should include PID
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Maria Pacana
:
Depends on:
Blocks: 49762
  Show dependency tree / graph
 
Reported: 2013-07-31 21:49 UTC by Roan Kattouw
Modified: 2014-10-28 18:13 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Roan Kattouw 2013-07-31 21:49:13 UTC 
Trying to interpret the Parsoid logging output is difficult because multiple workers' logs are multiplexed together. It would be great if the worker PID could be added to the start of the line, to make it possible to demultiplex the log file.
Comment 1 Gabriel Wicke 2013-08-13 20:59:35 UTC 
While doing this we should also replace all direct calls to console.log / console.warn / console.error with utility logging methods. We already have env.errCB and env is available widely, so we could probably add env.log and env.logError methods. Those could then be redefined depending on the context.

See also bug 49762 for other potential logging tweaks.
Comment 2 ssastry 2014-10-28 18:13:56 UTC 
Now that we have output sent to Logstash via bunyan, this is done.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links