Last modified: 2013-12-02 14:39:03 UTC
We need to listen for VE post-edit, which uses the post-edit mw.hook, rather than 'wgPostEdit'. This might be case for letting the transition system/shouldSkip directly listen to a mw.hook, as we discussed. If that's not ready yet, though, we could have GuidedTour listen and set an internal isPostEdit to true. This would then get set back to false when they activated VE.
This is basically critical for The Wikipedia Adventure (TWA), in order to advance the tour after using visual editor. It's important that TWA introduce new editors to the default editing interface and this fix would be the only way that could happen. I'm curious if there's any sense of the timeframe a fix? BTW, Guided Tours is fantastic.
(In reply to comment #0) > We need to listen for VE post-edit, which uses the post-edit mw.hook, rather > than 'wgPostEdit'. > > This might be case for letting the transition system/shouldSkip directly > listen > to a mw.hook, as we discussed. > > If that's not ready yet, though, we could have GuidedTour listen and set an > internal isPostEdit to true. This would then get set back to false when they > activated VE. James and Trevor, is this still the state of the world for VE?
(In reply to comment #2) > James and Trevor, is this still the state of the world for VE? I believe so. It fires the postEdit hook (like core), and I think deliberately doesn't touch wgPostEdit (a global boolean is not an ideal fit for an event that can occur multiple times without a reload).
Fixed in https://gerrit.wikimedia.org/r/#/c/92670/ . Forgot to put the bug ID.
Putting this against my work Bugzilla account so I ever actually find it again. :-)
