Last modified: 2013-08-01 18:54:14 UTC
VisualEditor.php attempts to register a hook handler that was removed (summary credit goes to Ori) stack: http://paste.tstarling.com/p/GuTJEM.html Tim says: > var_dump($wgHooks['BeforeWelcomeCreation']); array(2) { [0]=> string(42) "VisualEditorHooks::onBeforeWelcomeCreation" [1]=> string(44) "GettingStartedHooks::onBeforeWelcomeCreation" } > print is_callable($wgHooks['BeforeWelcomeCreation'][0]); > print is_callable($wgHooks['BeforeWelcomeCreation'][1]); 1
Ia4e2a7854b3a2a5cbbe4da
I removed the BeforeWelcomeCreation handler in I8be6198a6 but not the statement in VisualEditor.php that registered it. 1.22wmf11 had not yet been updated to I8be6198a6, so it didn't need to be fixed. 1.22wmf12 did need a fix, but there was a merged change separating the deployed commit and my fix: change I1cd9e2bea. I didn't know if it was safe to deploy and no one from the VE team was around, so I created a cut a 'bug/52368' branch based on the deployed commit, cherry picked the fix on top, and synced that. My apologies to the VisualEditor team and to the users that were affected.
