Last modified: 2013-08-29 15:11:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54413, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 52413 - Consider disabling empty catch body sniff
Consider disabling empty catch body sniff
Status: NEW
Product: Wikimedia
Classification: Unclassified
Continuous integration (Other open bugs)
unspecified
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-08-01 18:55 UTC by Niklas Laxström
Modified: 2013-08-29 15:11 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Niklas Laxström 2013-08-01 18:55:31 UTC 
I feel that empty catch bodies are okay - especially if they have comments why it is empty. Some examples:

https://gerrit.wikimedia.org/r/#/c/77094/1/tests/SpecialPagesTest.php
https://gerrit.wikimedia.org/r/#/c/77094/1/tag/PageTranslationHooks.php
Comment 1 Antoine "hashar" Musso (WMF) 2013-08-29 15:11:11 UTC 
You can get the rule removed in mediawiki/tools/codesniffer.git ruleset.xml

Then have the submodule updated in integration/jenkins.git.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links