Last modified: 2013-08-14 22:58:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54422, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 52422 - PreHandler: Pre-blocks are split across ws-only newlines


Summary:	PreHandler: Pre-blocks are split across ws-only newlines

Status:	RESOLVED FIXED

Product:	Parsoid
Classification:	Unclassified
Component:	token-stream transforms (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal normal
Target Milestone:	---
Assigned To:	ssastry

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-08-01 21:17 UTC by Ltrlg
Modified:	2013-08-14 22:58 UTC (History)
CC List:	1 user (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Ltrlg 2013-08-01 21:17:16 UTC

Detected on [[fr:YAML]], section "Nouvelles lignes rassemblées".

An implicit <pre> (without tags in wikitext, only by indentation) with a line containing only spaces is parsed by the MW native parser to one <pre>, by Parsoid to two <pre>, separated where this line stands.

Comment 1 ssastry 2013-08-02 04:45:13 UTC

Simplified test case to duplicate the problem:
-------------
 a

 b
-------------

Bug 49974 might also have a bearing on this bug.  Fixing that might automatically fix this -- just a hunch.

Comment 2 ssastry 2013-08-02 20:54:49 UTC

Actually, this is a bit more subtle than that.

" a\n\n b" renders as 2 pre-blocks in mediawiki
" a\n \n b" renders as a single pre-block in mediawiki.

So, I guess people rely on this subtle difference to render pre-blocks with newlines in between.  And, there is no relationship to bug 49974 anymore.

Comment 3 Gerrit Notification Bot 2013-08-02 22:16:21 UTC

Change 77458 had a related patch set uploaded by Subramanya Sastry:
(Bug 52422) Tweak PreHandler to handle WS-only lines between pre-blocks

https://gerrit.wikimedia.org/r/77458

Comment 4 Gerrit Notification Bot 2013-08-03 00:32:11 UTC

Change 77458 merged by jenkins-bot:
(Bug 52422) Tweak PreHandler to handle WS-only lines between pre-blocks

https://gerrit.wikimedia.org/r/77458

Comment 5 ssastry 2013-08-06 16:43:21 UTC

This bug is now fixed and rt-tested.  Will go live on next deploy next week. There are not going to be any deployments this week -- barring critical fixes -- since a large chunk of WMF staff is at wikimania.

Comment 6 ssastry 2013-08-14 22:58:29 UTC

Now deployed and verified fixed.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links